Re: [Qemu-devel] [PATCH v4 00/10] tcg mips64 and mips r6 improvements

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v4 00/10] tcg mips64 and mips r6 improvements
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
6174298 tcg-mips: Adjust qemu_ld/st for mips64
10d492b tcg-mips: Adjust calling conventions for mips64
77f5942 tcg-mips: Add tcg unwind info
15aca42 tcg-mips: Adjust prologue for mips64
fd0cad5 tcg-mips: Adjust load/store functions for mips64
7649ead tcg-mips: Adjust move functions for mips64
5b3e241 tcg-mips: Add bswap32u and bswap64
58015fb tcg-mips: Support 64-bit opcodes
fe521e5 tcg-mips: Add mips64 opcodes
3a87909 tcg-mips: Move bswap code to a subroutine

=== OUTPUT BEGIN ===
Checking PATCH 1/10: tcg-mips: Move bswap code to a subroutine...
Checking PATCH 2/10: tcg-mips: Add mips64 opcodes...
Checking PATCH 3/10: tcg-mips: Support 64-bit opcodes...
Checking PATCH 4/10: tcg-mips: Add bswap32u and bswap64...
Checking PATCH 5/10: tcg-mips: Adjust move functions for mips64...
Checking PATCH 6/10: tcg-mips: Adjust load/store functions for mips64...
Checking PATCH 7/10: tcg-mips: Adjust prologue for mips64...
Checking PATCH 8/10: tcg-mips: Add tcg unwind info...
Checking PATCH 9/10: tcg-mips: Adjust calling conventions for mips64...
Checking PATCH 10/10: tcg-mips: Adjust qemu_ld/st for mips64...
ERROR: externs should be avoided in .c files
#26: FILE: tcg/mips/tcg-target.inc.c:39:
+extern int link_error(void);

total: 1 errors, 0 warnings, 420 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden