[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 5/5] virtio-gpu: fix memory leak in resource attach b
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PULL 5/5] virtio-gpu: fix memory leak in resource attach backing |
Date: |
Tue, 3 Jan 2017 15:52:34 +0100 |
From: Li Qiang <address@hidden>
In the resource attach backing function, everytime it will
allocate 'res->iov' thus can leading a memory leak. This
patch avoid this.
Signed-off-by: Li Qiang <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>
---
hw/display/virtio-gpu.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
index 6a26258..ca88cf4 100644
--- a/hw/display/virtio-gpu.c
+++ b/hw/display/virtio-gpu.c
@@ -714,6 +714,11 @@ virtio_gpu_resource_attach_backing(VirtIOGPU *g,
return;
}
+ if (res->iov) {
+ cmd->error = VIRTIO_GPU_RESP_ERR_UNSPEC;
+ return;
+ }
+
ret = virtio_gpu_create_mapping_iov(&ab, cmd, &res->addrs, &res->iov);
if (ret != 0) {
cmd->error = VIRTIO_GPU_RESP_ERR_UNSPEC;
--
1.8.3.1
- [Qemu-devel] [PULL 0/5] virtio-gpu: misc bugfixes., Gerd Hoffmann, 2017/01/03
- [Qemu-devel] [PULL 1/5] display: virtio-gpu-3d: check virgl capabilities max_size, Gerd Hoffmann, 2017/01/03
- [Qemu-devel] [PULL 2/5] virtio-gpu: track and limit host memory allocations, Gerd Hoffmann, 2017/01/03
- [Qemu-devel] [PULL 5/5] virtio-gpu: fix memory leak in resource attach backing,
Gerd Hoffmann <=
- [Qemu-devel] [PULL 3/5] virtio-gpu: call cleanup mapping function in resource destroy, Gerd Hoffmann, 2017/01/03
- [Qemu-devel] [PULL 4/5] virtio-gpu-3d: fix memory leak in resource attach backing, Gerd Hoffmann, 2017/01/03
- Re: [Qemu-devel] [PULL 0/5] virtio-gpu: misc bugfixes., Peter Maydell, 2017/01/05