[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 4/5] virtio-gpu-3d: fix memory leak in resource attac
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PULL 4/5] virtio-gpu-3d: fix memory leak in resource attach backing |
Date: |
Tue, 3 Jan 2017 15:52:33 +0100 |
From: Li Qiang <address@hidden>
If the virgl_renderer_resource_attach_iov function fails the
'res_iovs' will be leaked. Add check of the return value to
free the 'res_iovs' when failing.
Signed-off-by: Li Qiang <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>
---
hw/display/virtio-gpu-3d.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/hw/display/virtio-gpu-3d.c b/hw/display/virtio-gpu-3d.c
index e29f099..b13ced3 100644
--- a/hw/display/virtio-gpu-3d.c
+++ b/hw/display/virtio-gpu-3d.c
@@ -291,8 +291,11 @@ static void virgl_resource_attach_backing(VirtIOGPU *g,
return;
}
- virgl_renderer_resource_attach_iov(att_rb.resource_id,
- res_iovs, att_rb.nr_entries);
+ ret = virgl_renderer_resource_attach_iov(att_rb.resource_id,
+ res_iovs, att_rb.nr_entries);
+
+ if (ret != 0)
+ virtio_gpu_cleanup_mapping_iov(res_iovs, att_rb.nr_entries);
}
static void virgl_resource_detach_backing(VirtIOGPU *g,
--
1.8.3.1
- [Qemu-devel] [PULL 0/5] virtio-gpu: misc bugfixes., Gerd Hoffmann, 2017/01/03
- [Qemu-devel] [PULL 1/5] display: virtio-gpu-3d: check virgl capabilities max_size, Gerd Hoffmann, 2017/01/03
- [Qemu-devel] [PULL 2/5] virtio-gpu: track and limit host memory allocations, Gerd Hoffmann, 2017/01/03
- [Qemu-devel] [PULL 5/5] virtio-gpu: fix memory leak in resource attach backing, Gerd Hoffmann, 2017/01/03
- [Qemu-devel] [PULL 3/5] virtio-gpu: call cleanup mapping function in resource destroy, Gerd Hoffmann, 2017/01/03
- [Qemu-devel] [PULL 4/5] virtio-gpu-3d: fix memory leak in resource attach backing,
Gerd Hoffmann <=
- Re: [Qemu-devel] [PULL 0/5] virtio-gpu: misc bugfixes., Peter Maydell, 2017/01/05