[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 02/11] aspeed/smc: remove call to aspeed_smc_upda
From: |
Cédric Le Goater |
Subject: |
[Qemu-devel] [PATCH v2 02/11] aspeed/smc: remove call to aspeed_smc_update_cs() in reset function |
Date: |
Mon, 9 Jan 2017 17:24:38 +0100 |
Instead, we can simply set the irq level when unselecting the slave
devices. This change prepares ground for a subsequent cleanup of the
aspeed_smc_update_cs() routine which uselessly loops on all slaves to
update their status.
Signed-off-by: Cédric Le Goater <address@hidden>
---
hw/ssi/aspeed_smc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c
index 8a7217d4df6c..205c0abfae98 100644
--- a/hw/ssi/aspeed_smc.c
+++ b/hw/ssi/aspeed_smc.c
@@ -424,6 +424,7 @@ static void aspeed_smc_reset(DeviceState *d)
/* Unselect all slaves */
for (i = 0; i < s->num_cs; ++i) {
s->regs[s->r_ctrl0 + i] |= CTRL_CE_STOP_ACTIVE;
+ qemu_set_irq(s->cs_lines[i], true);
}
/* setup default segment register values for all */
@@ -431,8 +432,6 @@ static void aspeed_smc_reset(DeviceState *d)
s->regs[R_SEG_ADDR0 + i] =
aspeed_smc_segment_to_reg(&s->ctrl->segments[i]);
}
-
- aspeed_smc_update_cs(s);
}
static uint64_t aspeed_smc_read(void *opaque, hwaddr addr, unsigned int size)
--
2.7.4
- [Qemu-devel] [PATCH v2 00/11] Aspeed SMC controller fixes and improvements, Cédric Le Goater, 2017/01/09
- [Qemu-devel] [PATCH v2 01/11] aspeed/smc: remove call to reset in realize function, Cédric Le Goater, 2017/01/09
- [Qemu-devel] [PATCH v2 02/11] aspeed/smc: remove call to aspeed_smc_update_cs() in reset function,
Cédric Le Goater <=
- [Qemu-devel] [PATCH v2 03/11] aspeed/smc: rework the prototype of the AspeedSMCFlash helper routines, Cédric Le Goater, 2017/01/09
- [Qemu-devel] [PATCH v2 04/11] aspeed/smc: autostrap CE0/1 configuration, Cédric Le Goater, 2017/01/09
- [Qemu-devel] [PATCH v2 05/11] aspeed/smc: unfold the AspeedSMCController array, Cédric Le Goater, 2017/01/09
- [Qemu-devel] [PATCH v2 06/11] aspeed/smc: adjust the size of the register region, Cédric Le Goater, 2017/01/09
- [Qemu-devel] [PATCH v2 07/11] aspeed/smc: handle SPI flash Command mode, Cédric Le Goater, 2017/01/09