Re: [Qemu-devel] [PATCH 1/2] qemu-options: Rename variables on the -numa "cpus" option

[Peter Maydell]

On 23 January 2017 at 18:06, Eduardo Habkost <address@hidden> wrote:
> Use @var{firstcpu} and @var{lastcpu} to make the metasyntatic
> variables a bit clearer. While doing this, use @var only around
> the metasyntatic variables, not including the square brackets and
> hyphen.
>
> The semantics of the "cpus" option will be clarified by rewriting
> the whole -numa documentation in a follow-up patch.
>
> Reported-by: Peter Maydell <address@hidden>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
>  qemu-options.hx | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 80df52651a..780528d6ad 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -119,11 +119,11 @@ specifies the maximum number of hotpluggable CPUs.
>  ETEXI
>
>  DEF("numa", HAS_ARG, QEMU_OPTION_numa,
> -    "-numa node[,mem=size][,cpus=cpu[-cpu]][,nodeid=node]\n"
> -    "-numa node[,memdev=id][,cpus=cpu[-cpu]][,nodeid=node]\n", QEMU_ARCH_ALL)
> +    "-numa node[,mem=size][,cpus=firstcpu[-lastcpu]][,nodeid=node]\n"
> +    "-numa node[,memdev=id][,cpus=firstcpu[-lastcpu]][,nodeid=node]\n", 
> QEMU_ARCH_ALL)
>  STEXI
> address@hidden -numa node[,address@hidden,address@hidden,address@hidden
> address@hidden -numa node[,address@hidden,address@hidden,address@hidden
> address@hidden -numa 
> node[,address@hidden,address@hidden@var{lastcpu}]][,address@hidden
> address@hidden -numa 
> node[,address@hidden,address@hidden@var{lastcpu}]][,address@hidden
>  @findex -numa
>  Simulate a multi node NUMA system. If @samp{mem}, @samp{memdev}
>  and @samp{cpus} are omitted, resources are split equally. Also, note

Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM