[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/14] check-qdict: Simplify qdict_crumple_test_
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 02/14] check-qdict: Simplify qdict_crumple_test_recursive() |
Date: |
Sat, 18 Feb 2017 11:49:54 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 02/17/2017 02:38 PM, Markus Armbruster wrote:
>> Use qdict_get_qdict(), qdict_get_qlist() instead of qdict_get()
>> followed by qobject_to_qdict(), qobject_to_qlist().
>
> Worth a Coccinelle script to make sure we catch it all?
I'm pretty sure I got them all: I examined all uses of the QType
enumeration constants for this series.
>>
>> While there, drop some redundant code.
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>> tests/check-qdict.c | 25 +++++++++----------------
>> 1 file changed, 9 insertions(+), 16 deletions(-)
>>
>
> Reviewed-by: Eric Blake <address@hidden>
Thanks!
- [Qemu-devel] [PATCH 00/14] qobject: Cleanups, mostly in tests, Markus Armbruster, 2017/02/17
- [Qemu-devel] [PATCH 01/14] qdict: Make qdict_get_qlist() safe like qdict_get_qdict(), Markus Armbruster, 2017/02/17
- [Qemu-devel] [PATCH 02/14] check-qdict: Simplify qdict_crumple_test_recursive(), Markus Armbruster, 2017/02/17
- [Qemu-devel] [PATCH 11/14] tests: Don't check qobject_type() before qobject_to_qfloat(), Markus Armbruster, 2017/02/17
- [Qemu-devel] [PATCH 06/14] test-qmp-event: Simplify and tighten event_test_emit(), Markus Armbruster, 2017/02/17
- [Qemu-devel] [PATCH 10/14] tests: Don't check qobject_type() before qobject_to_qint(), Markus Armbruster, 2017/02/17
- [Qemu-devel] [PATCH 07/14] Don't check qobject_type() before qobject_to_qdict(), Markus Armbruster, 2017/02/17
- [Qemu-devel] [PATCH 09/14] tests: Don't check qobject_type() before qobject_to_qstring(), Markus Armbruster, 2017/02/17