[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 22/26] test-qobject-input-visitor: Cover miss
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 22/26] test-qobject-input-visitor: Cover missing nested struct member |
Date: |
Tue, 28 Feb 2017 10:00:13 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 02/26/2017 03:43 PM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> tests/test-qobject-input-visitor.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/tests/test-qobject-input-visitor.c
> b/tests/test-qobject-input-visitor.c
> index 10c15c4..6e04736 100644
> --- a/tests/test-qobject-input-visitor.c
> +++ b/tests/test-qobject-input-visitor.c
> @@ -894,7 +894,7 @@ static void
> test_visitor_in_fail_struct_missing(TestInputVisitorData *data,
> char *str;
> double dbl;
>
> - v = visitor_input_test_init(data, "{}");
> + v = visitor_input_test_init(data, "{ 'sub': [ {} ] }");
> visit_start_struct(v, NULL, NULL, 0, &error_abort);
> visit_start_struct(v, "struct", NULL, 0, &err);
> error_free_or_abort(&err);
> @@ -920,6 +920,11 @@ static void
> test_visitor_in_fail_struct_missing(TestInputVisitorData *data,
> error_free_or_abort(&err);
> visit_type_null(v, "null", &err);
> error_free_or_abort(&err);
> + visit_start_list(v, "sub", NULL, 0, &error_abort);
> + visit_start_struct(v, NULL, NULL, 0, &error_abort);
> + visit_type_int(v, "i64", &i64, &err);
> + error_free_or_abort(&err);
> + visit_end_struct(v, NULL);
> visit_end_struct(v, NULL);
Missing a visit_end_list, no?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 00/26] qapi: QMP dispatch and input visitor work, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 08/26] qmp: Improve QMP dispatch error messages, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 01/26] qga: Fix crash on non-dictionary QMP argument, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 11/26] qapi: Make QObject input visitor set *list reliably, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 02/26] libqtest: Work around a "QMP wants a newline" bug, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 13/26] qapi: Drop string input visitor method optional(), Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 22/26] test-qobject-input-visitor: Cover missing nested struct member, Markus Armbruster, 2017/02/26
- Re: [Qemu-devel] [PATCH v2 22/26] test-qobject-input-visitor: Cover missing nested struct member,
Eric Blake <=
- [Qemu-devel] [PATCH v2 10/26] qapi: Clean up after commit 3d344c2, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 04/26] qmp: Dumb down how we run QMP command registration, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 19/26] test-string-input-visitor: Tear down existing test automatically, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 12/26] qapi: Improve qobject input visitor error reporting, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 23/26] qapi: Make input visitors detect unvisited list tails, Markus Armbruster, 2017/02/26