Re: [Qemu-devel] [PATCH v2 9/9] tpm: Added support for TPM emulator

[Amarnath Valluri]

On 07.04.2017 18:11, Marc-André Lureau wrote:
> Hi
>
> On Fri, Apr 7, 2017 at 4:41 PM Daniel P. Berrange
>
>     > +        .name = "data-path",
>     > +        .type = QEMU_OPT_STRING,
>     > +        .help = "Socket path to use for data exhange",
>     > +    },
>     > +    {
>     > +        .name = "ctrl-path",
>     > +        .type = QEMU_OPT_STRING,
>     > +        .help = "Socket path to use for out-of-band control
>     messages",
>     > +    },
>
>     I'm still not convinced by the need for 2 separate UNIX sockets,
>     unless
>     there's a performance reason, but that looks unlikely.
>
>
> We would also need something more than an implementation of the 
> protocol that qemu is going to rely on as an external dependency.  A 
> protocol specification would help to start the discussion.
I would agree with you, Can we adopt the current swtpm's control 
interface as initial proposal.
> Alternatively, I would suggest to not rely on a public protocol,
What do you mean by public protocol here, can you please help me 
understanding this.

- Amarnath