qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4] qga: Add support network interfacestatistics


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v4] qga: Add support network interfacestatistics in
Date: Wed, 26 Apr 2017 08:24:34 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0

On 04/25/2017 08:20 PM, address@hidden wrote:
> > +   */> +        colon = strchr(line, ':')> +        if (!colon) {> +       
>      continue> +        }> +        *colon = '\0'> +        if (colon - 
> path_len >= line && strcmp(colon - path_len, path) == 0) {colon - path_len > 
> line would imply the current line isn't a matcheither, so i think that can be 
> tightened to colon - path_len == line.

Ouch. Your mailer doesn't know how to quote properly, rendering your
email illegible.

> 
> ------------
> 
> The text reading from /proc/net/dev/ is  aligned to the right. so i think it 
> should be colon - path_len >= line

<snip>

> 发件人: address@hidden
> 收件人:芦志朋10108272
> 抄送人:芦志朋10108272 address@hidden
> 日 期 :2017年04月26日 05:17
> 主 题 :Re: [Qemu-devel] [PATCH v4] qga: Add support network interfacestatistics 
> in
> 

Also, we prefer that you do not top-post on technical lists, but instead
reply inline to the relevant portions of the email.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]