Re: [Qemu-devel] [PULL 00/33] Misc patches for 2017-06-01

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PULL 00/33] Misc patches for 2017-06-01

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
1ebbf04 kvm: don't register smram_listener when smm is off
f4b3f7c nbd: make it thread-safe, fix qcow2 over nbd
d4a18e8 hw/core: nmi.c can be compiled as common-obj nowadays
c06c4af target/i386: Add GDB XML description for SSE registers
4344a48 i386/kvm: do not zero out segment flags if segment is unusable or not 
present
e86883d edu: fix memory leak on msi_broken platforms
be6d7fd linuxboot_dma: compile for i486
14947d1 kvmclock: update system_time_msr address forcibly
5001e27 qtest: add rtc periodic timer test
97bb2fa nbd: Fully initialize client in case of failed negotiation
5d9ae3d exec: fix address_space_get_iotlb_entry page mask
f778d29 sockets: improve error reporting if UNIX socket path is too long
d7a4856 i386: fix read/write cr with icount option
188dc83 target/i386: use multiple CPU AddressSpaces
8efdf10 target/i386: enable A20 automatically in system management mode
cc48f9a vhost-user-scsi: Introduce a vhost-user-scsi sample application
f2e2614 vhost-user-scsi: Introduce vhost-user-scsi host device
8b2ecdf virtio-scsi: Unset hotplug handler when unrealize
7d172d8 exec: simplify phys_page_find() params
cc24c0d nbd/client.c: use errp instead of LOG
8581947 nbd: add errp to read_sync, write_sync and drop_sync
049fa7e nbd: add errp parameter to nbd_wr_syncv()
6715ff30 nbd: read_sync and friends: return 0 on success
7ebb76e nbd: strict nbd_wr_syncv
3e8b635 Check the return value of fcntl in qemu_set_cloexec
cb9ada7 kvm: irqchip: skip update msi when disabled
302dc31 msix: trace control bit write op
fb29a24 kvm: irqchip: trace changes on msi add/remove
e6cd374 mc146818rtc: embrace all x86 specific code
88f77c2 mc146818rtc: drop unnecessary '#ifdef TARGET_I386'
546abbc mc146818rtc: ensure LOST_TICK_POLICY_SLEW is only enabled on TARGET_I386
1b2152e mc146818rtc: precisely count the clock for periodic timer
472d959 mc146818rtc: update periodic timer only if it is needed

=== OUTPUT BEGIN ===
Checking PATCH 1/33: mc146818rtc: update periodic timer only if it is needed...
Checking PATCH 2/33: mc146818rtc: precisely count the clock for periodic 
timer...
ERROR: braces {} are necessary for all arms of this statement
#129: FILE: hw/timer/mc146818rtc.c:216:
+        if (s->lost_tick_policy == LOST_TICK_POLICY_SLEW) {
[...]
+        } else
[...]

total: 1 errors, 0 warnings, 181 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/33: mc146818rtc: ensure LOST_TICK_POLICY_SLEW is only enabled 
on TARGET_I386...
Checking PATCH 4/33: mc146818rtc: drop unnecessary '#ifdef TARGET_I386'...
Checking PATCH 5/33: mc146818rtc: embrace all x86 specific code...
Checking PATCH 6/33: kvm: irqchip: trace changes on msi add/remove...
Checking PATCH 7/33: msix: trace control bit write op...
Checking PATCH 8/33: kvm: irqchip: skip update msi when disabled...
Checking PATCH 9/33: Check the return value of fcntl in qemu_set_cloexec...
Checking PATCH 10/33: nbd: strict nbd_wr_syncv...
Checking PATCH 11/33: nbd: read_sync and friends: return 0 on success...
Checking PATCH 12/33: nbd: add errp parameter to nbd_wr_syncv()...
Checking PATCH 13/33: nbd: add errp to read_sync, write_sync and drop_sync...
Checking PATCH 14/33: nbd/client.c: use errp instead of LOG...
ERROR: code indent should never use tabs
#126: FILE: nbd/client.c:729:
+^I     Error **errp)$

total: 1 errors, 0 warnings, 158 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 15/33: exec: simplify phys_page_find() params...
Checking PATCH 16/33: virtio-scsi: Unset hotplug handler when unrealize...
Checking PATCH 17/33: vhost-user-scsi: Introduce vhost-user-scsi host device...
Checking PATCH 18/33: vhost-user-scsi: Introduce a vhost-user-scsi sample 
application...
Checking PATCH 19/33: target/i386: enable A20 automatically in system 
management mode...
Checking PATCH 20/33: target/i386: use multiple CPU AddressSpaces...
Checking PATCH 21/33: i386: fix read/write cr with icount option...
Checking PATCH 22/33: sockets: improve error reporting if UNIX socket path is 
too long...
Checking PATCH 23/33: exec: fix address_space_get_iotlb_entry page mask...
Checking PATCH 24/33: nbd: Fully initialize client in case of failed 
negotiation...
Checking PATCH 25/33: qtest: add rtc periodic timer test...
Checking PATCH 26/33: kvmclock: update system_time_msr address forcibly...
Checking PATCH 27/33: linuxboot_dma: compile for i486...
Checking PATCH 28/33: edu: fix memory leak on msi_broken platforms...
Checking PATCH 29/33: i386/kvm: do not zero out segment flags if segment is 
unusable or not present...
Checking PATCH 30/33: target/i386: Add GDB XML description for SSE registers...
Checking PATCH 31/33: hw/core: nmi.c can be compiled as common-obj nowadays...
Checking PATCH 32/33: nbd: make it thread-safe, fix qcow2 over nbd...
Checking PATCH 33/33: kvm: don't register smram_listener when smm is off...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden