[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v3 19/23] migration/block: reset dirty bitmap before
From: |
Fam Zheng |
Subject: |
[Qemu-devel] [PULL v3 19/23] migration/block: reset dirty bitmap before reading |
Date: |
Thu, 8 Jun 2017 19:56:39 +0800 |
From: Paolo Bonzini <address@hidden>
Any data that is returned by read may be stale already, the bitmap
has to be cleared before issuing the read.
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Fam Zheng <address@hidden>
---
migration/block.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/migration/block.c b/migration/block.c
index 0b3926e..7ed42c6 100644
--- a/migration/block.c
+++ b/migration/block.c
@@ -537,6 +537,8 @@ static int mig_save_device_dirty(QEMUFile *f,
BlkMigDevState *bmds,
} else {
nr_sectors = BDRV_SECTORS_PER_DIRTY_CHUNK;
}
+ bdrv_reset_dirty_bitmap(bmds->dirty_bitmap, sector, nr_sectors);
+
blk = g_new(BlkMigBlock, 1);
blk->buf = g_malloc(BLOCK_SIZE);
blk->bmds = bmds;
@@ -569,7 +571,6 @@ static int mig_save_device_dirty(QEMUFile *f,
BlkMigDevState *bmds,
g_free(blk);
}
- bdrv_reset_dirty_bitmap(bmds->dirty_bitmap, sector, nr_sectors);
sector += nr_sectors;
bmds->cur_dirty = sector;
--
2.9.4
- [Qemu-devel] [PULL v3 06/23] block: access quiesce_counter with atomic ops, (continued)
- [Qemu-devel] [PULL v3 06/23] block: access quiesce_counter with atomic ops, Fam Zheng, 2017/06/08
- [Qemu-devel] [PULL v3 08/23] block: access serialising_in_flight with atomic ops, Fam Zheng, 2017/06/08
- [Qemu-devel] [PULL v3 09/23] block: access wakeup with atomic ops, Fam Zheng, 2017/06/08
- [Qemu-devel] [PULL v3 11/23] throttle-groups: only start one coroutine from drained_begin, Fam Zheng, 2017/06/08
- [Qemu-devel] [PULL v3 12/23] throttle-groups: do not use qemu_co_enter_next, Fam Zheng, 2017/06/08
- [Qemu-devel] [PULL v3 13/23] throttle-groups: protect throttled requests with a CoMutex, Fam Zheng, 2017/06/08
- [Qemu-devel] [PULL v3 10/23] block: access io_plugged with atomic ops, Fam Zheng, 2017/06/08
- [Qemu-devel] [PULL v3 14/23] util: add stats64 module, Fam Zheng, 2017/06/08
- [Qemu-devel] [PULL v3 15/23] block: use Stat64 for wr_highest_offset, Fam Zheng, 2017/06/08
- [Qemu-devel] [PULL v3 16/23] block: access write_gen with atomics, Fam Zheng, 2017/06/08
- [Qemu-devel] [PULL v3 19/23] migration/block: reset dirty bitmap before reading,
Fam Zheng <=
- [Qemu-devel] [PULL v3 17/23] block: protect tracked_requests and flush_queue with reqs_lock, Fam Zheng, 2017/06/08
- [Qemu-devel] [PULL v3 18/23] block: introduce dirty_bitmap_mutex, Fam Zheng, 2017/06/08
- [Qemu-devel] [PULL v3 20/23] block: protect modification of dirty bitmaps with a mutex, Fam Zheng, 2017/06/08
- [Qemu-devel] [PULL v3 21/23] block: introduce block_account_one_io, Fam Zheng, 2017/06/08
- [Qemu-devel] [PULL v3 22/23] block: split BlockAcctStats creation and setup, Fam Zheng, 2017/06/08
- [Qemu-devel] [PULL v3 23/23] block: make accounting thread-safe, Fam Zheng, 2017/06/08
- Re: [Qemu-devel] [PULL v3 00/23] Docker and block patches, Peter Maydell, 2017/06/12