qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RISU PATCH v5 02/13] README: document the coding style


From: Peter Maydell
Subject: Re: [Qemu-devel] [RISU PATCH v5 02/13] README: document the coding style used for risu
Date: Tue, 20 Jun 2017 13:54:19 +0100

On 19 June 2017 at 11:46, Alex Bennée <address@hidden> wrote:
> We also include the an Emacs .dir-locals (as per QEMU) that enforces
> this layout.
>
> Signed-off-by: Alex Bennée <address@hidden>
> ---
>  .dir-locals.el | 2 ++
>  README         | 9 +++++++++
>  2 files changed, 11 insertions(+)
>  create mode 100644 .dir-locals.el
>
> diff --git a/.dir-locals.el b/.dir-locals.el
> new file mode 100644
> index 0000000..3ac0cfc
> --- /dev/null
> +++ b/.dir-locals.el
> @@ -0,0 +1,2 @@
> +((c-mode . ((c-file-style . "stroustrup")
> +           (indent-tabs-mode . nil))))

This prompted me to look at this, and this is wrong: it
overrides my local emacs config with something that gets
some bits of style wrong :-( Indeed there's one in QEMU
now I see, and that is why my emacs behaviour has regressed.
For instance given

static const VMStateDescription cmsdk_apb_uart_vmstate = {
    .name = "cmsdk-apb-uart",
    .version_id = 1,
    .minimum_version_id = 1,
    .fields = (VMStateField[]) {
        VMSTATE_END_OF_LIST()


with cursor on the blank line at the end, if I type '}' then I get
     }\n
(ie the cursor moves to a new line) but the cursor should
stay after the '}' so I can type the ','.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]