Re: [Qemu-devel] [PATCH 1/2] risu_reginfo_arm.c: Fix handling of size values in sigframe

[Peter Maydell]

On 20 June 2017 at 16:03, Alex Bennée <address@hidden> wrote:
>
> Peter Maydell <address@hidden> writes:
>
>> The code in reginfo_init_vfp() to parse the signal frame
>> was mishandling the size counts:
>>  * the size includes the bytes for the magic and size fields,
>>    so the code to skip forward over unknown or undersize blocks
>>    was adding 4 more than it should
>>  * the size is in bytes but the "is this block too small"
>>    test was checking against an expected size in words
>>
>> This didn't cause any problems because the kernel happens
>> to generate signal frames with the VFP section first.
>>
>> Signed-off-by: Peter Maydell <address@hidden>
>
> I guess this would have tripped up once the kernel started dumping SVE
> registers in the context?

Probably not if it put them after the VFP registers (where
you'd expect them to be), though if we supported SVE regs in
risu we'd probably have found this bug in the process of
getting that working ;-)

thanks
-- PMM