Re: [Qemu-devel] [PATCH 04/22] vl: convert -tb-size to qemu_strtoul

[Richard Henderson]

On 07/03/2017 09:34 AM, Paolo Bonzini wrote:
> -extern int tcg_tb_size;
> +extern unsigned long tcg_tb_size;

size_t would be more natural.

I don't think we support any hosts for which sizeof(size_t) != sizeof(unsigned 
long), but perhaps

        unsigned lomg tmp;
        if (qemu_strtoul(optarg, NULL, 0, &tmp) < 0
            || tmp != (size_t)tmp) {
          error_report("Invalid argument to -tb-size");
          exit(1);
        }
        tcg_tb_size = tmp;

where I'd expect the extra comparison to be optimized away.

But I'm not overly concerned either way, so

Reviewed-by: Richard Henderson <address@hidden>


r~