[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are corouti
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are coroutine_fn |
Date: |
Wed, 5 Jul 2017 12:06:18 -0400 (EDT) |
Hi
----- Original Message -----
>
>
> On 05/07/2017 16:21, Marc-André Lureau wrote:
> >>
> >> They are, but it's an implementation detail. Why is this patch necessary?
> > I didn't think this would be controversial :) well, the checks I added to
> > clang verify function pointer share the coroutine attribute.
> >
> > The function themself are/need to be coroutine_fn (as they will call
> > coroutine_fn too)
>
> It's not controversial, I would not have expected the functions to call
> coroutine_fn. :) How do they do that?
>
For example, null_co_readv() calls null_co_common() which calls
co_aio_sleep_ns()
- [Qemu-devel] [PATCH 05/35] coroutine: remove coroutine_fn from qemu_co_queue_run_restart(), (continued)
- [Qemu-devel] [PATCH 05/35] coroutine: remove coroutine_fn from qemu_co_queue_run_restart(), Marc-André Lureau, 2017/07/04
- [Qemu-devel] [PATCH 06/35] coroutine: mark CoRwLock coroutine_fn, Marc-André Lureau, 2017/07/04
- [Qemu-devel] [PATCH 07/35] blockjob: mark coroutine_fn, Marc-André Lureau, 2017/07/04
- [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are coroutine_fn, Marc-André Lureau, 2017/07/04
- Re: [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are coroutine_fn, Paolo Bonzini, 2017/07/05
- Re: [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are coroutine_fn, Marc-André Lureau, 2017/07/05
- Re: [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are coroutine_fn, Paolo Bonzini, 2017/07/05
- Re: [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are coroutine_fn,
Marc-André Lureau <=
- Re: [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are coroutine_fn, Paolo Bonzini, 2017/07/05
- Re: [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are coroutine_fn, Marc-André Lureau, 2017/07/05
- Re: [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are coroutine_fn, Paolo Bonzini, 2017/07/05
[Qemu-devel] [PATCH 09/35] block: bdrv_create() and bdrv_debug_event() are coroutine_fn, Marc-André Lureau, 2017/07/04
[Qemu-devel] [PATCH 11/35] qcow2: mark coroutine_fn, Marc-André Lureau, 2017/07/04
[Qemu-devel] [PATCH 10/35] vmdk: mark coroutine_fn, Marc-André Lureau, 2017/07/04
[Qemu-devel] [PATCH 12/35] raw: mark coroutine_fn, Marc-André Lureau, 2017/07/04