Re: [Qemu-devel] [PATCH 06/35] coroutine: mark CoRwLock coroutine_fn

[Stefan Hajnoczi]

On Wed, Jul 05, 2017 at 12:03:17AM +0200, Marc-André Lureau wrote:
>   CC      util/qemu-coroutine-lock.o
> /home/elmarco/src/qemu/util/qemu-coroutine-lock.c:371:5: warning: calling 
> function 'qemu_co_mutex_lock' requires holding role '_coroutine_fn' 
> exclusively [-Wthread-safety-analysis]
>     qemu_co_mutex_lock(&lock->mutex);
>     ^
> /home/elmarco/src/qemu/util/qemu-coroutine-lock.c:371:5: warning: calling 
> function 'qemu_co_mutex_lock' requires holding role '_coroutine_fn' 
> exclusively [-Wthread-safety-analysis]
> /home/elmarco/src/qemu/util/qemu-coroutine-lock.c:374:9: warning: calling 
> function 'qemu_co_queue_wait' requires holding role '_coroutine_fn' 
> exclusively [-Wthread-safety-analysis]
>         qemu_co_queue_wait(&lock->queue, &lock->mutex);
>         ^
> /home/elmarco/src/qemu/util/qemu-coroutine-lock.c:374:9: warning: calling 
> function 'qemu_co_queue_wait' requires holding role '_coroutine_fn' 
> exclusively [-Wthread-safety-analysis]
> /home/elmarco/src/qemu/util/qemu-coroutine-lock.c:377:5: warning: calling 
> function 'qemu_co_mutex_unlock' requires holding role '_coroutine_fn' 
> exclusively [-Wthread-safety-analysis]
>     qemu_co_mutex_unlock(&lock->mutex);
>     ^
> /home/elmarco/src/qemu/util/qemu-coroutine-lock.c:377:5: warning: calling 
> function 'qemu_co_mutex_unlock' requires holding role '_coroutine_fn' 
> exclusively [-Wthread-safety-analysis]
> /home/elmarco/src/qemu/util/qemu-coroutine-lock.c:390:9: warning: calling 
> function 'qemu_co_queue_restart_all' requires holding role '_coroutine_fn' 
> exclusively [-Wthread-safety-analysis]
>         qemu_co_queue_restart_all(&lock->queue);
>         ^
> /home/elmarco/src/qemu/util/qemu-coroutine-lock.c:390:9: warning: calling 
> function 'qemu_co_queue_restart_all' requires holding role '_coroutine_fn' 
> exclusively [-Wthread-safety-analysis]
> /home/elmarco/src/qemu/util/qemu-coroutine-lock.c:394:9: warning: calling 
> function 'qemu_co_mutex_lock' requires holding role '_coroutine_fn' 
> exclusively [-Wthread-safety-analysis]
>         qemu_co_mutex_lock(&lock->mutex);
>         ^
> /home/elmarco/src/qemu/util/qemu-coroutine-lock.c:394:9: warning: calling 
> function 'qemu_co_mutex_lock' requires holding role '_coroutine_fn' 
> exclusively [-Wthread-safety-analysis]
> /home/elmarco/src/qemu/util/qemu-coroutine-lock.c:399:13: warning: calling 
> function 'qemu_co_queue_next' requires holding role '_coroutine_fn' 
> exclusively [-Wthread-safety-analysis]
>             qemu_co_queue_next(&lock->queue);
>             ^
> /home/elmarco/src/qemu/util/qemu-coroutine-lock.c:399:13: warning: calling 
> function 'qemu_co_queue_next' requires holding role '_coroutine_fn' 
> exclusively [-Wthread-safety-analysis]
> /home/elmarco/src/qemu/util/qemu-coroutine-lock.c:402:5: warning: calling 
> function 'qemu_co_mutex_unlock' requires holding role '_coroutine_fn' 
> exclusively [-Wthread-safety-analysis]
>     qemu_co_mutex_unlock(&lock->mutex);
>     ^
> /home/elmarco/src/qemu/util/qemu-coroutine-lock.c:402:5: warning: calling 
> function 'qemu_co_mutex_unlock' requires holding role '_coroutine_fn' 
> exclusively [-Wthread-safety-analysis]
> /home/elmarco/src/qemu/util/qemu-coroutine-lock.c:407:5: warning: calling 
> function 'qemu_co_mutex_lock' requires holding role '_coroutine_fn' 
> exclusively [-Wthread-safety-analysis]
>     qemu_co_mutex_lock(&lock->mutex);
>     ^
> /home/elmarco/src/qemu/util/qemu-coroutine-lock.c:407:5: warning: calling 
> function 'qemu_co_mutex_lock' requires holding role '_coroutine_fn' 
> exclusively [-Wthread-safety-analysis]
> /home/elmarco/src/qemu/util/qemu-coroutine-lock.c:410:9: warning: calling 
> function 'qemu_co_queue_wait' requires holding role '_coroutine_fn' 
> exclusively [-Wthread-safety-analysis]
>         qemu_co_queue_wait(&lock->queue, &lock->mutex);
>         ^
> /home/elmarco/src/qemu/util/qemu-coroutine-lock.c:410:9: warning: calling 
> function 'qemu_co_queue_wait' requires holding role '_coroutine_fn' 
> exclusively [-Wthread-safety-analysis]
> 
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  include/qemu/coroutine.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Stefan Hajnoczi <address@hidden>

signature.asc
Description: PGP signature