Re: [Qemu-devel] [PATCH v1 3/6] Convert error_report() to warn_report()

[Alistair Francis]

On Thu, Jul 6, 2017 at 5:14 PM,  <address@hidden> wrote:
>>>>>> "Alistair" == Alistair Francis <address@hidden> writes:
>
> Alistair> Convert all uses of error_report("[Ww]arning:"... to use
> Alistair> warn_report() instead. This helps standardise on a single
> Alistair> method of printing warnings to the user.
>
> In a number of cases the initial double quote has been removed as
> well.  This will have to be fixed.
> e.g.,
> -        error_report("Warning: 'filename' option specified. "
> +        warn_report('filename' option specified. "

Yeah, I thought I saw this when I was doing it, but then everything
compiled so I figured it was fine.

It must not all be included with the default ./configure, because I
just tried again and it all compiles for me.

I'll fix these up in the next version.

Thanks,
Alistair

>
> I'm surprised the result compiled cleanly.
>
> Peter C
>
>
> --
> Dr Peter Chubb         Tel: +61 2 9490 5852      http://ts.data61.csiro.au/
> Trustworthy Systems Group                           Data61 (formerly NICTA)