[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 3/6] Convert error_report() to warn_report()
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v1 3/6] Convert error_report() to warn_report() |
Date: |
Mon, 10 Jul 2017 10:06:18 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Alistair Francis <address@hidden> writes:
> On Thu, Jul 6, 2017 at 5:14 PM, <address@hidden> wrote:
>>>>>>> "Alistair" == Alistair Francis <address@hidden> writes:
>>
>> Alistair> Convert all uses of error_report("[Ww]arning:"... to use
>> Alistair> warn_report() instead. This helps standardise on a single
>> Alistair> method of printing warnings to the user.
>>
>> In a number of cases the initial double quote has been removed as
>> well. This will have to be fixed.
>> e.g.,
>> - error_report("Warning: 'filename' option specified. "
>> + warn_report('filename' option specified. "
>
> Yeah, I thought I saw this when I was doing it, but then everything
> compiled so I figured it was fine.
>
> It must not all be included with the default ./configure, because I
> just tried again and it all compiles for me.
The result of ./configure depends on the packages you got installed.
You need quite a few development packages to get anywhere near a full
compile. For a first step, you could do worse than installing your
distribution's QEMU package's build dependencies.
[...]
Re: [Qemu-devel] [PATCH v1 3/6] Convert error_report() to warn_report(), Greg Kurz, 2017/07/07
Re: [Qemu-devel] [PATCH v1 3/6] Convert error_report() to warn_report(), Cornelia Huck, 2017/07/07
Re: [Qemu-devel] [PATCH v1 3/6] Convert error_report() to warn_report(), Eduardo Habkost, 2017/07/07
Re: [Qemu-devel] [PATCH v1 3/6] Convert error_report() to warn_report(), Stefan Hajnoczi, 2017/07/07
Re: [Qemu-devel] [PATCH v1 3/6] Convert error_report() to warn_report(), Markus Armbruster, 2017/07/07