Re: [Qemu-devel] [PATCH v13 00/26] translate: [tcg] Generic translation framework

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v13 00/26] translate: [tcg] Generic translation 
framework

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
dc3923c target/arm: [tcg] Port to generic translation framework
cf50855 target/arm: [tcg, a64] Port to disas_log
d333f58 target/arm: [tcg] Port to disas_log
760a365 target/arm: [tcg, a64] Port to tb_stop
4ff55a7 target/arm: [tcg] Port to tb_stop
94a2eed target/arm: [tcg, a64] Port to translate_insn
d1a3990 target/arm: [tcg] Port to translate_insn
a8ccf26 target/arm: [tcg, a64] Port to breakpoint_check
ce8ef1c target/arm: [tcg] Port to breakpoint_check
a2a561e target/arm: [tcg, a64] Port to insn_start
5b77def target/arm: [tcg] Port to insn_start
033fd32 target/arm: [tcg] Port to tb_start
6d31278 target/arm: [tcg, a64] Port to init_disas_context
2b136cb target/arm: [tcg] Port to init_disas_context
4e52d9c target/arm: [tcg] Port to DisasContextBase
b3c0a87 target/i386: [tcg] Port to generic translation framework
e70a33c target/i386: [tcg] Port to disas_log
fff0ca1 target/i386: [tcg] Port to tb_stop
6ec3f13 target/i386: [tcg] Port to translate_insn
6d3aefa target/i386: [tcg] Port to breakpoint_check
6529981 target/i386: [tcg] Port to insn_start
9e05cd3 target/i386: [tcg] Port to init_disas_context
7323661 target/i386: [tcg] Port to DisasContextBase
fc4b55b target: [tcg] Add generic translation framework
7612ad2 target: [tcg] Use a generic enum for DISAS_ values
5e64387 Pass generic CPUState to gen_intermediate_code()

=== OUTPUT BEGIN ===
Checking PATCH 1/26: Pass generic CPUState to gen_intermediate_code()...
WARNING: line over 80 characters
#123: FILE: target/arm/translate.h:158:
+static inline void gen_intermediate_code_a64(CPUState *cpu, TranslationBlock 
*tb)

total: 0 errors, 1 warnings, 303 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 2/26: target: [tcg] Use a generic enum for DISAS_ values...
Checking PATCH 3/26: target: [tcg] Add generic translation framework...
Checking PATCH 4/26: target/i386: [tcg] Port to DisasContextBase...
WARNING: line over 80 characters
#500: FILE: target/i386/translate.c:8516:
+                != ((dc->base.pc_next + TARGET_MAX_INSN_SIZE - 1) & 
TARGET_PAGE_MASK)

WARNING: line over 80 characters
#540: FILE: target/i386/translate.c:8554:
+        log_target_disas(cs, dc->base.pc_first, dc->base.pc_next - 
dc->base.pc_first,

total: 0 errors, 2 warnings, 491 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 5/26: target/i386: [tcg] Port to init_disas_context...
Checking PATCH 6/26: target/i386: [tcg] Port to insn_start...
Checking PATCH 7/26: target/i386: [tcg] Port to breakpoint_check...
Checking PATCH 8/26: target/i386: [tcg] Port to translate_insn...
Checking PATCH 9/26: target/i386: [tcg] Port to tb_stop...
Checking PATCH 10/26: target/i386: [tcg] Port to disas_log...
WARNING: line over 80 characters
#37: FILE: target/i386/translate.c:8536:
+    log_target_disas(cpu, dc->base.pc_first, dc->base.pc_next - 
dc->base.pc_first,

total: 0 errors, 1 warnings, 42 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 11/26: target/i386: [tcg] Port to generic translation 
framework...
Checking PATCH 12/26: target/arm: [tcg] Port to DisasContextBase...
WARNING: line over 80 characters
#53: FILE: target/arm/translate-a64.c:351:
+    if (s->base.singlestep_enabled || s->ss_active || (s->base.tb->cflags & 
CF_LAST_IO)) {

WARNING: line over 80 characters
#220: FILE: target/arm/translate-a64.c:11223:
+    dc->mmu_idx = core_to_arm_mmu_idx(env, 
ARM_TBFLAG_MMUIDX(dc->base.tb->flags));

ERROR: line over 90 characters
#274: FILE: target/arm/translate-a64.c:11288:
+                           included in [dc->base.tb->pc, dc->base.tb->pc + 
dc->base.tb->size) in order

WARNING: line over 80 characters
#287: FILE: target/arm/translate-a64.c:11300:
+        if (dc->base.num_insns == max_insns && (dc->base.tb->cflags & 
CF_LAST_IO)) {

ERROR: space required before the open parenthesis '('
#775: FILE: target/arm/translate.c:12092:
+        switch(dc->base.is_jmp) {

WARNING: line over 80 characters
#848: FILE: target/arm/translate.h:164:
+static inline void gen_intermediate_code_a64(DisasContextBase *db, CPUState 
*cpu,

total: 2 errors, 4 warnings, 759 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 13/26: target/arm: [tcg] Port to init_disas_context...
WARNING: line over 80 characters
#72: FILE: target/arm/translate.c:11810:
+    dc->mmu_idx = core_to_arm_mmu_idx(env, 
ARM_TBFLAG_MMUIDX(dc->base.tb->flags));

total: 0 errors, 1 warnings, 120 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 14/26: target/arm: [tcg, a64] Port to init_disas_context...
Checking PATCH 15/26: target/arm: [tcg] Port to tb_start...
Checking PATCH 16/26: target/arm: [tcg] Port to insn_start...
Checking PATCH 17/26: target/arm: [tcg, a64] Port to insn_start...
Checking PATCH 18/26: target/arm: [tcg] Port to breakpoint_check...
Checking PATCH 19/26: target/arm: [tcg, a64] Port to breakpoint_check...
Checking PATCH 20/26: target/arm: [tcg] Port to translate_insn...
ERROR: suspect code indent for conditional statements (4, 4)
#200: FILE: target/arm/translate.c:12095:
+    if (dc->base.is_jmp != DISAS_SKIP) {
     if (tb->cflags & CF_LAST_IO) {

total: 1 errors, 0 warnings, 216 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 21/26: target/arm: [tcg, a64] Port to translate_insn...
Checking PATCH 22/26: target/arm: [tcg] Port to tb_stop...
Checking PATCH 23/26: target/arm: [tcg, a64] Port to tb_stop...
Checking PATCH 24/26: target/arm: [tcg] Port to disas_log...
Checking PATCH 25/26: target/arm: [tcg, a64] Port to disas_log...
Checking PATCH 26/26: target/arm: [tcg] Port to generic translation framework...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden