Re: [Qemu-devel] [PATCH v5 4/6] xlnx_zynqmp: Convert to DEFINE_PROP_LINK

[Philippe Mathieu-Daudé]

On 07/16/2017 11:38 PM, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

> ---
>   hw/arm/xlnx-zynqmp.c | 7 ++-----
>   1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c
> index 64f52f8..cd8a4aa 100644
> --- a/hw/arm/xlnx-zynqmp.c
> +++ b/hw/arm/xlnx-zynqmp.c
> @@ -140,11 +140,6 @@ static void xlnx_zynqmp_init(Object *obj)
>                                     &error_abort);
>       }
>   
> -    object_property_add_link(obj, "ddr-ram", TYPE_MEMORY_REGION,
> -                             (Object **)&s->ddr_ram,
> -                             qdev_prop_allow_set_link_before_realize,
> -                             OBJ_PROP_LINK_UNREF_ON_RELEASE, &error_abort);
> -
>       object_initialize(&s->gic, sizeof(s->gic), gic_class_name());
>       qdev_set_parent_bus(DEVICE(&s->gic), sysbus_get_default());
>   
> @@ -434,6 +429,8 @@ static Property xlnx_zynqmp_props[] = {
>       DEFINE_PROP_STRING("boot-cpu", XlnxZynqMPState, boot_cpu),
>       DEFINE_PROP_BOOL("secure", XlnxZynqMPState, secure, false),
>       DEFINE_PROP_BOOL("has_rpu", XlnxZynqMPState, has_rpu, false),
> +    DEFINE_PROP_LINK("ddr-ram", XlnxZynqMPState, ddr_ram, TYPE_MEMORY_REGION,
> +                     MemoryRegion *),
>       DEFINE_PROP_END_OF_LIST()
>   };
>