[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 23/31] target/sh4: Unify code for CHECK_PRIVILEGED
From: |
Aurelien Jarno |
Subject: |
[Qemu-devel] [PULL 23/31] target/sh4: Unify code for CHECK_PRIVILEGED |
Date: |
Tue, 18 Jul 2017 23:50:42 +0200 |
From: Richard Henderson <address@hidden>
We do not need to emit N copies of raising an exception.
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Aurelien Jarno <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Aurelien Jarno <address@hidden>
---
target/sh4/translate.c | 14 ++++----------
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/target/sh4/translate.c b/target/sh4/translate.c
index acd756e18a..2476b948b9 100644
--- a/target/sh4/translate.c
+++ b/target/sh4/translate.c
@@ -369,16 +369,9 @@ static inline void gen_store_fpr64(DisasContext *ctx,
TCGv_i64 t, int reg)
goto do_illegal_slot; \
}
-#define CHECK_PRIVILEGED \
- if (IS_USER(ctx)) { \
- gen_save_cpu_state(ctx, true); \
- if (ctx->envflags & DELAY_SLOT_MASK) { \
- gen_helper_raise_slot_illegal_instruction(cpu_env); \
- } else { \
- gen_helper_raise_illegal_instruction(cpu_env); \
- } \
- ctx->bstate = BS_EXCP; \
- return; \
+#define CHECK_PRIVILEGED \
+ if (IS_USER(ctx)) { \
+ goto do_illegal; \
}
#define CHECK_FPU_ENABLED \
@@ -1793,6 +1786,7 @@ static void _decode_opc(DisasContext * ctx)
ctx->opcode, ctx->pc);
fflush(stderr);
#endif
+ do_illegal:
if (ctx->envflags & DELAY_SLOT_MASK) {
do_illegal_slot:
gen_save_cpu_state(ctx, true);
--
2.11.0
- [Qemu-devel] [PULL 29/31] target/sh4: Add missing FPSCR.PR == 0 checks, (continued)
- [Qemu-devel] [PULL 29/31] target/sh4: Add missing FPSCR.PR == 0 checks, Aurelien Jarno, 2017/07/18
- [Qemu-devel] [PULL 20/31] target/sh4: Load/store Dr as 64-bit quantities, Aurelien Jarno, 2017/07/18
- [Qemu-devel] [PULL 10/31] target/sh4: Handle user-space atomics, Aurelien Jarno, 2017/07/18
- [Qemu-devel] [PULL 28/31] target/sh4: Implement fpchg, Aurelien Jarno, 2017/07/18
- [Qemu-devel] [PULL 04/31] target/sh4: do not use a helper to implement fneg, Aurelien Jarno, 2017/07/18
- [Qemu-devel] [PULL 22/31] target/sh4: Unify code for CHECK_NOT_DELAY_SLOT, Aurelien Jarno, 2017/07/18
- [Qemu-devel] [PULL 03/31] target/sh4: fix FPSCR cause vs flag inversion, Aurelien Jarno, 2017/07/18
- [Qemu-devel] [PULL 27/31] target/sh4: Introduce CHECK_SH4A, Aurelien Jarno, 2017/07/18
- [Qemu-devel] [PULL 11/31] target/sh4: Recognize common gUSA sequences, Aurelien Jarno, 2017/07/18
- [Qemu-devel] [PULL 08/31] target/sh4: Keep env->flags clean, Aurelien Jarno, 2017/07/18
- [Qemu-devel] [PULL 23/31] target/sh4: Unify code for CHECK_PRIVILEGED,
Aurelien Jarno <=
- [Qemu-devel] [PULL 12/31] linux-user/sh4: Notice gUSA regions during signal delivery, Aurelien Jarno, 2017/07/18
- [Qemu-devel] [PULL 16/31] target/sh4: Pass DisasContext to fpr64 routines, Aurelien Jarno, 2017/07/18
- [Qemu-devel] [PULL 15/31] target/sh4: Unify cpu_fregs into FREG, Aurelien Jarno, 2017/07/18
- Re: [Qemu-devel] [PULL 00/31] target/sh4 queue, no-reply, 2017/07/18
- Re: [Qemu-devel] [PULL 00/31] target/sh4 queue, no-reply, 2017/07/18
- Re: [Qemu-devel] [PULL 00/31] target/sh4 queue, Peter Maydell, 2017/07/19