Re: [Qemu-devel] [PATCH v14 07/34] target/arm: Set is_jmp properly after single-stepping

[Richard Henderson]

On 07/21/2017 11:37 AM, Emilio G. Cota wrote:
> >                           gen_exception_internal_insn(dc, 0, EXCP_DEBUG);
> > +                        dc->is_jmp = DISAS_NORETURN;
>
> gen_exception_internal_insn already sets dc->is_jmp to DISAS_NORETURN,
> as per patch 04/34:
> @@ -304,7 +304,7 @@ static void gen_exception_internal_insn(DisasContext *s, 
> int offset, int excp)
>   {
>       gen_a64_set_pc_im(s->pc - offset);
>       gen_exception_internal(excp);
> -    s->is_jmp = DISAS_EXC;
> +    s->is_jmp = DISAS_NORETURN;
>   }
>
> This applies to both arm and a64.
>
> Why do we need to set is_jmp again, then?

Because I confused gen_exception_internal, which does not.
I have dropped this patch.


r~