[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 47/47] script to find outdated entry in MAIN
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [RFC PATCH 47/47] script to find outdated entry in MAINTAINERS |
Date: |
Fri, 28 Jul 2017 18:26:27 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Philippe Mathieu-Daudé <address@hidden> writes:
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> scripts/check_maintainer.sh | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
> create mode 100755 scripts/check_maintainer.sh
>
> diff --git a/scripts/check_maintainer.sh b/scripts/check_maintainer.sh
> new file mode 100755
> index 0000000000..074a6acf69
> --- /dev/null
> +++ b/scripts/check_maintainer.sh
> @@ -0,0 +1,21 @@
> +#! /bin/bash
> +#
> +# This script checks MAINTAINERS consistency
Consistency? I think you mean coverage.
> +#
> +# Copyright (C) 2017 Philippe Mathieu-Daudé. GPLv2+.
> +#
> +# Usage:
> +# ./scripts/check_maintainer.sh | tee MAINTAINERS.missing
> +
> +echo "Incorrect MAINTAINERS paths:" 1>&2
> +egrep ^F: MAINTAINERS | cut -d\ -f2 | while read p; do
> + ls -ld $p 1>/dev/null
> +done
> +
> +echo "No maintainers found for:" 1>&2
> +git ls-files|while read f; do
> + OUT=$(./scripts/get_maintainer.pl -f $f 2>&1)
> + if [[ "$OUT" == *"No maintainers found"* ]]; then
> + echo $f
> + fi
> +done
Good idea.
But what I really want is checkpatch whining when it happens. Thomas
posted a patch some time ago. Would you be willing to revive it?
https://lists.gnu.org/archive/html/qemu-devel/2017-01/msg05742.html
Message-Id: <address@hidden>
Basically:
* Patch deletes a file
- still in MAINTAINERS after the patch: warn
- else: ok
* Patch creates a file
- not in in MAINTAINERS after the patch: warn
- else: ok
* Patch moves a file
- old still in MAINTAINERS after the patch: warn
- new not in in MAINTAINERS after the patch: warn
- neither: ok
May have to ignore "uninteresting" files to reduce the noise. But even
ignoring everything but *.[ch] would be an improvement!
- [Qemu-devel] [PATCH 40/47] MAINTAINERS: add missing entry for AIO, (continued)
- [Qemu-devel] [PATCH 40/47] MAINTAINERS: add missing entry for AIO, Philippe Mathieu-Daudé, 2017/07/28
- [Qemu-devel] [RFC PATCH 41/47] MAINTAINERS: add missing I2C entries, Philippe Mathieu-Daudé, 2017/07/28
- [Qemu-devel] [RFC PATCH 43/47] MAINTAINERS: add missing TPM entries, Philippe Mathieu-Daudé, 2017/07/28
- [Qemu-devel] [RFC PATCH 42/47] MAINTAINERS: add missing Bluetooth entries, Philippe Mathieu-Daudé, 2017/07/28
- [Qemu-devel] [RFC PATCH 44/47] MAINTAINERS: add missing entry for tilegx, Philippe Mathieu-Daudé, 2017/07/28
- [Qemu-devel] [RFC PATCH 45/47] MAINTAINERS: add missing entries for loader, Philippe Mathieu-Daudé, 2017/07/28
- [Qemu-devel] [RFC PATCH 47/47] script to find outdated entry in MAINTAINERS, Philippe Mathieu-Daudé, 2017/07/28
- [Qemu-devel] [RFC PATCH 46/47] MAINTAINERS: add missing entries for Coccinelle scripts, Philippe Mathieu-Daudé, 2017/07/28
- Re: [Qemu-devel] [RFC PATCH 46/47] MAINTAINERS: add missing entries for Coccinelle scripts, Eric Blake, 2017/07/28