qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v7 2/6] qmp: Create IOThrottle structure


From: Pradeep Jagadeesh
Subject: Re: [Qemu-devel] [PATCH v7 2/6] qmp: Create IOThrottle structure
Date: Tue, 8 Aug 2017 14:30:43 +0200
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0

On 8/8/2017 1:30 PM, Alberto Garcia wrote:
On Mon 07 Aug 2017 04:48:38 PM CEST, Markus Armbruster wrote:
Awkward question for a v7, but here goes anyway: why is IOThrottle
worth its very own .json file?
I feel this is a common throttle structure that is used by block
devices as well as fsdev, so moved to a separate file.
I'm not sure that's a good idea.  Kevin, Berto, what do you think?

Mmm... I don't have a very strong opinion, but if there's no actual need
to move it to a separate file I'd prefer to leave it where it is.
The segregation is the solid reason. Because throttling is a feature that is used by fsdev, block may many more in future. I do not see moving it back to block does it make any sense?

Regards,
Pradeep


Berto





reply via email to

[Prev in Thread] Current Thread [Next in Thread]