[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 4/5] Convert multi-line fprintf() to warn_rep
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 4/5] Convert multi-line fprintf() to warn_report() |
|
Date: |
Tue, 15 Aug 2017 07:41:21 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Alistair Francis <address@hidden> writes:
> On Mon, Aug 14, 2017 at 6:30 AM, Markus Armbruster <address@hidden> wrote:
[...]
>> Drop the periods from the warning messages, and you may add
>> Reviewed-by: Markus Armbruster <address@hidden>
>>
>> I encourage you to also use the opportunity to improve line breaks.
>>
>> I'm not asking you to fix the other issues with the messages.
>
> I'm happy to fix them. Do you want them fixed in this commit or split
> into a seperate commit?
Separate would keep this one mostly mechanical. Announcing the followup
work in the commit message would help reviewers. Something like
"several warning messages could use improvement; will be addressed
shortly".