[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 1/2] libqtest: add qtest_accel() to avoid wa
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [RFC PATCH 1/2] libqtest: add qtest_accel() to avoid warnings when kvm is not available |
Date: |
Tue, 15 Aug 2017 13:40:05 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 08/15/2017 01:27 PM, Philippe Mathieu-Daudé wrote:
> On 08/15/2017 03:13 PM, Eric Blake wrote:
>> On 08/15/2017 11:39 AM, Philippe Mathieu-Daudé wrote:
>>> only warn once about it.
>>>
>>> - kernel without kvm:
>>>
>>> # make check-qtest-x86_64
>>> GTESTER check-qtest-x86_64
>>> Could not access KVM kernel module: No such device
>>> qemu-system-x86_64: failed to initialize KVM: No such device
>>> qemu-system-x86_64: Back to tcg accelerator
>>
>> How does this differ from what commit 2f6b38d1 was trying to do?
>
> I'd say 2f6b38d1 is for common end-user usage while this is for
> QA/testers usage. If you run N qtests with the same machine arguments,
> having this warning displayed only once is enough and allow you to focus
> on the tests output.
I guess my question is: Are we still getting a warning output even with
2f6b38d1 applied? If so, why, because the point of that commit was to
avoid the warning.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH 2/2] tests: use qtest_accel(), Philippe Mathieu-Daudé, 2017/08/15