[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 for-2.11 10/10] target/s390x: cleanup cpu.h
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH v1 for-2.11 10/10] target/s390x: cleanup cpu.h |
Date: |
Thu, 17 Aug 2017 15:09:25 +0200 |
On Thu, 17 Aug 2017 14:41:34 +0200
Thomas Huth <address@hidden> wrote:
> On 17.08.2017 11:22, David Hildenbrand wrote:
> > Let's reshuffle the function prototypes so we get a cleaner outline
> > of the files.
> >
> > Reviewed-by: Richard Henderson <address@hidden>
> > Signed-off-by: David Hildenbrand <address@hidden>
> > ---
> > target/s390x/cpu.h | 140
> > ++++++++++++++++++++++++++---------------------------
> > 1 file changed, 69 insertions(+), 71 deletions(-)
>
> Not sure whether this code churn here is really worth the effort ... I'd
> prefer to introduce file-specific headers for the prototypes instead,
> e.g. helper.h, mmu_helper.h, etc. ... but that's just my 0.02 € ... I
> also won't object if this patch gets included as is.
I'll stare a bit more at it to decide whether this is worthwile...
- Re: [Qemu-devel] [PATCH v1 for-2.11 09/10] s390x/kvm: move KVM declarations and stubs to separate files, (continued)
- Re: [Qemu-devel] [PATCH v1 for-2.11 09/10] s390x/kvm: move KVM declarations and stubs to separate files, David Hildenbrand, 2017/08/17
- Re: [Qemu-devel] [PATCH v1 for-2.11 09/10] s390x/kvm: move KVM declarations and stubs to separate files, Thomas Huth, 2017/08/17
- Re: [Qemu-devel] [PATCH v1 for-2.11 09/10] s390x/kvm: move KVM declarations and stubs to separate files, Cornelia Huck, 2017/08/17
- Re: [Qemu-devel] [PATCH v1 for-2.11 09/10] s390x/kvm: move KVM declarations and stubs to separate files, David Hildenbrand, 2017/08/17
- Re: [Qemu-devel] [PATCH v1 for-2.11 09/10] s390x/kvm: move KVM declarations and stubs to separate files, David Hildenbrand, 2017/08/17
[Qemu-devel] [PATCH v1 for-2.11 10/10] target/s390x: cleanup cpu.h, David Hildenbrand, 2017/08/17
Re: [Qemu-devel] [PATCH v1 for-2.11 00/10] target/s390x: cleanup cpu.h, Philippe Mathieu-Daudé, 2017/08/17
Re: [Qemu-devel] [PATCH v1 for-2.11 00/10] target/s390x: cleanup cpu.h, Cornelia Huck, 2017/08/17