[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v7 03/11] qemu.py: use os.path.null instead of /dev/
From: |
Amador Pahim |
Subject: |
[Qemu-devel] [PATCH v7 03/11] qemu.py: use os.path.null instead of /dev/null |
Date: |
Fri, 18 Aug 2017 19:05:18 +0200 |
For increased portability, let's use os.path.devnull.
Signed-off-by: Amador Pahim <address@hidden>
---
scripts/qemu.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/qemu.py b/scripts/qemu.py
index ef531bb23b..51545f7f97 100644
--- a/scripts/qemu.py
+++ b/scripts/qemu.py
@@ -78,7 +78,7 @@ class QEMUMachine(object):
fd_param = ["%s" % self._socket_scm_helper,
"%d" % self._qmp.get_sock_fd(),
"%s" % fd_file_path]
- devnull = open('/dev/null', 'rb')
+ devnull = open(os.path.devnull, 'rb')
p = subprocess.Popen(fd_param, stdin=devnull, stdout=subprocess.PIPE,
stderr=subprocess.STDOUT)
output = p.communicate()[0]
@@ -139,7 +139,7 @@ class QEMUMachine(object):
def launch(self):
'''Launch the VM and establish a QMP connection'''
- devnull = open('/dev/null', 'rb')
+ devnull = open(os.path.devnull, 'rb')
qemulog = open(self._qemu_log_path, 'wb')
try:
self._pre_launch()
--
2.13.5
- Re: [Qemu-devel] [PATCH v7 02/11] qemu.py: avoid writing to stdout/stderr, (continued)
[Qemu-devel] [PATCH v7 05/11] qemu.py: cleanup redundant calls in launch(), Amador Pahim, 2017/08/18
[Qemu-devel] [PATCH v7 04/11] qemu.py: use poll() instead of 'returncode', Amador Pahim, 2017/08/18
[Qemu-devel] [PATCH v7 11/11] qemu.py: refactor launch(), Amador Pahim, 2017/08/18
[Qemu-devel] [PATCH v7 08/11] qemu.py: make sure we only remove files we create, Amador Pahim, 2017/08/18
[Qemu-devel] [PATCH v7 09/11] qemu.py: launch vm only if it's not running, Amador Pahim, 2017/08/18
[Qemu-devel] [PATCH v7 01/11] qemu.py: fix is_running() return before first launch(), Amador Pahim, 2017/08/18
[Qemu-devel] [PATCH v7 03/11] qemu.py: use os.path.null instead of /dev/null,
Amador Pahim <=
Re: [Qemu-devel] [PATCH v7 00/11] scripts/qemu.py fixes and cleanups, Eduardo Habkost, 2017/08/31