[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 09/11] qemu.py: launch vm only if it's not ru
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v7 09/11] qemu.py: launch vm only if it's not running |
Date: |
Tue, 22 Aug 2017 18:37:09 +0800 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Fri, 08/18 19:05, Amador Pahim wrote:
> A new call to launch() with a running VM will fall in exception and
> consequently call shutdown().
>
> This patch makes launch() to raise an exception when it's called with VM
> already running.
>
> Signed-off-by: Amador Pahim <address@hidden>
> ---
> scripts/qemu.py | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/scripts/qemu.py b/scripts/qemu.py
> index 9ae65e454e..46e8ff3232 100644
> --- a/scripts/qemu.py
> +++ b/scripts/qemu.py
> @@ -170,6 +170,9 @@ class QEMUMachine(object):
> self._iolog = None
> self._qemu_full_args = None
> devnull = open(os.path.devnull, 'rb')
> + if self.is_running():
> + raise QEMULaunchError('VM already running')
> +
> try:
> self._pre_launch()
> self._qemu_full_args = (self._wrapper + [self._binary] +
> --
> 2.13.5
>
Reviewed-by: Fam Zheng <address@hidden>
- Re: [Qemu-devel] [PATCH v7 02/11] qemu.py: avoid writing to stdout/stderr, (continued)
[Qemu-devel] [PATCH v7 05/11] qemu.py: cleanup redundant calls in launch(), Amador Pahim, 2017/08/18
[Qemu-devel] [PATCH v7 04/11] qemu.py: use poll() instead of 'returncode', Amador Pahim, 2017/08/18
[Qemu-devel] [PATCH v7 11/11] qemu.py: refactor launch(), Amador Pahim, 2017/08/18
[Qemu-devel] [PATCH v7 08/11] qemu.py: make sure we only remove files we create, Amador Pahim, 2017/08/18
[Qemu-devel] [PATCH v7 09/11] qemu.py: launch vm only if it's not running, Amador Pahim, 2017/08/18
- Re: [Qemu-devel] [PATCH v7 09/11] qemu.py: launch vm only if it's not running,
Fam Zheng <=
[Qemu-devel] [PATCH v7 01/11] qemu.py: fix is_running() return before first launch(), Amador Pahim, 2017/08/18
[Qemu-devel] [PATCH v7 03/11] qemu.py: use os.path.null instead of /dev/null, Amador Pahim, 2017/08/18
Re: [Qemu-devel] [PATCH v7 00/11] scripts/qemu.py fixes and cleanups, Eduardo Habkost, 2017/08/31