Re: [Qemu-devel] [PATCH 00/15] Convert over to use keycodemapdb

[Gerd Hoffmann]

On Thu, 2017-08-10 at 16:55 +0100, Daniel P. Berrange wrote:
> The keycodemap project[1] provides a database mapping between
> many different keysym/keycode/scancode sets, along with a
> tool to generate mapping/lookup tables in various programming
> languages. It is already used by GTK-VNC, SPICE-GTK and
> libvirt.
> 
> This series enables its use in QEMU, thus fixing a great
> many bugs/ommissions in the 15+ key mapping tables people
> have manually written for QEMU.

Looks good on a quick look.  I'll have a closer look and test once I'm
done processing my vacation email backlog.

One thing for now:  I think we should not require the keycodemapdb at
build time.   Instead commit the generated files to git so the build
works without the submodule, then update the generated files each time
the submodule is updated (simliar to firmware blobs/submodules).

cheers,
  Gerd