[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC v2 15/32] vhost+postcopy: Register new regions with th
From: |
Dr. David Alan Gilbert (git) |
Subject: |
[Qemu-devel] [RFC v2 15/32] vhost+postcopy: Register new regions with the ufd |
Date: |
Thu, 24 Aug 2017 20:27:13 +0100 |
From: "Dr. David Alan Gilbert" <address@hidden>
When new regions are sent to the client using SET_MEM_TABLE, register
them with the userfaultfd.
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
---
contrib/libvhost-user/libvhost-user.c | 32 ++++++++++++++++++++++++++++++++
1 file changed, 32 insertions(+)
diff --git a/contrib/libvhost-user/libvhost-user.c
b/contrib/libvhost-user/libvhost-user.c
index e8accf11db..e6ab059a03 100644
--- a/contrib/libvhost-user/libvhost-user.c
+++ b/contrib/libvhost-user/libvhost-user.c
@@ -449,6 +449,38 @@ vu_set_mem_table_exec(VuDev *dev, VhostUserMsg *vmsg)
dev_region->mmap_addr);
}
+ if (dev->postcopy_listening) {
+ /* We should already have an open ufd need to mark each memory
+ * range as ufd.
+ * Note: Do we need any madvises? Well it's not been accessed
+ * yet, still probably need no THP to be safe, discard to be safe?
+ */
+ struct uffdio_register reg_struct;
+ reg_struct.range.start = (uintptr_t)dev_region->mmap_addr;
+ reg_struct.range.len = dev_region->size + dev_region->mmap_offset;
+ reg_struct.mode = UFFDIO_REGISTER_MODE_MISSING;
+
+ if (ioctl(dev->postcopy_ufd, UFFDIO_REGISTER, ®_struct)) {
+ vu_panic(dev, "%s: Failed to userfault region %d "
+ "@%p + %zx: (ufd=%d)%s\n",
+ __func__, i,
+ dev_region->mmap_addr,
+ dev_region->size + dev_region->mmap_offset,
+ dev->postcopy_ufd, strerror(errno));
+ continue;
+ }
+ if (!(reg_struct.ioctls & ((__u64)1 << _UFFDIO_COPY))) {
+ vu_panic(dev, "%s Region (%d) doesn't support COPY",
+ __func__, i);
+ continue;
+ }
+ DPRINT("%s: region %d: Registered userfault for %llx + %llx\n",
+ __func__, i, reg_struct.range.start, reg_struct.range.len);
+ /* TODO: Stash 'zero' support flags somewhere */
+ /* TODO: Get address back to QEMU */
+
+ }
+
close(vmsg->fds[i]);
}
--
2.13.5
- Re: [Qemu-devel] [RFC v2 09/32] vhost-user: Add 'VHOST_USER_POSTCOPY_ADVISE' message, (continued)
- [Qemu-devel] [RFC v2 10/32] vhub: Support sending fds back to qemu, Dr. David Alan Gilbert (git), 2017/08/24
- [Qemu-devel] [RFC v2 11/32] vhub: Open userfaultfd, Dr. David Alan Gilbert (git), 2017/08/24
- [Qemu-devel] [RFC v2 12/32] postcopy: Allow registering of fd handler, Dr. David Alan Gilbert (git), 2017/08/24
- [Qemu-devel] [RFC v2 13/32] vhost+postcopy: Register shared ufd with postcopy, Dr. David Alan Gilbert (git), 2017/08/24
- [Qemu-devel] [RFC v2 14/32] vhost+postcopy: Transmit 'listen' to client, Dr. David Alan Gilbert (git), 2017/08/24
- [Qemu-devel] [RFC v2 15/32] vhost+postcopy: Register new regions with the ufd,
Dr. David Alan Gilbert (git) <=
- [Qemu-devel] [RFC v2 16/32] vhost+postcopy: Send address back to qemu, Dr. David Alan Gilbert (git), 2017/08/24
- [Qemu-devel] [RFC v2 17/32] vhost+postcopy: Stash RAMBlock and offset, Dr. David Alan Gilbert (git), 2017/08/24
- [Qemu-devel] [RFC v2 18/32] vhost+postcopy: Send requests to source for shared pages, Dr. David Alan Gilbert (git), 2017/08/24
- [Qemu-devel] [RFC v2 19/32] vhost+postcopy: Resolve client address, Dr. David Alan Gilbert (git), 2017/08/24
- [Qemu-devel] [RFC v2 20/32] postcopy: wake shared, Dr. David Alan Gilbert (git), 2017/08/24
- [Qemu-devel] [RFC v2 21/32] postcopy: postcopy_notify_shared_wake, Dr. David Alan Gilbert (git), 2017/08/24