[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/5] virtio-ccw: use ccw data stream
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH 3/5] virtio-ccw: use ccw data stream |
Date: |
Wed, 6 Sep 2017 14:54:26 +0200 |
On Wed, 6 Sep 2017 14:49:52 +0200
Halil Pasic <address@hidden> wrote:
> On 09/06/2017 02:42 PM, Cornelia Huck wrote:
> > On Tue, 5 Sep 2017 13:16:43 +0200
> > Halil Pasic <address@hidden> wrote:
> >> @@ -488,7 +446,8 @@ static int virtio_ccw_cb(SubchDev *sch, CCW1 ccw)
> >> } else {
> >> virtio_bus_get_vdev_config(&dev->bus, vdev->config);
> >> /* XXX config space endianness */
> >
> > Unrelated: That should be fine, I guess?
> >
> >> - cpu_physical_memory_write(ccw.cda, vdev->config, len);
> >> + /* TODO we may have made -EINVAL out of -EFAULT */
> >
> > Eek.
> >
>
> Actually I wanted to send a patch which gets rid of the -EFAULT case
> in sch_handle_start_func_virtual.
>
> IMHO a program check is more appropriate here. We did the EFAULT if
> cpu_physical_memory_map failed, but we don't have that any more.
OK, such a patch would make this easier to figure out.
[Qemu-devel] [PATCH 1/5] s390x/css: introduce css data stream, Halil Pasic, 2017/09/05
- Re: [Qemu-devel] [PATCH 1/5] s390x/css: introduce css data stream, Cornelia Huck, 2017/09/06
- Re: [Qemu-devel] [PATCH 1/5] s390x/css: introduce css data stream, Halil Pasic, 2017/09/06
- Re: [Qemu-devel] [PATCH 1/5] s390x/css: introduce css data stream, Cornelia Huck, 2017/09/06
- Re: [Qemu-devel] [PATCH 1/5] s390x/css: introduce css data stream, Halil Pasic, 2017/09/11
- Re: [Qemu-devel] [PATCH 1/5] s390x/css: introduce css data stream, Cornelia Huck, 2017/09/13
- Re: [Qemu-devel] [PATCH 1/5] s390x/css: introduce css data stream, Halil Pasic, 2017/09/13