Re: [Qemu-devel] [PATCH v6 2/6] docker: don't rely on submodules existing in the main checkout

[Alistair Francis]

On Thu, Sep 28, 2017 at 2:44 AM, Fam Zheng <address@hidden> wrote:
> On Thu, 09/28 09:44, Daniel P. Berrange wrote:
>> When building the tarball to pass into the docker/vm test image,
>> the code relies on the git submodules being checked out in the
>> main checkout.
>>
>> ie if the developer has not run 'git submodule update --init dtc'
>> most (all?) of the docker tests will fail due to the missing dtc
>> package in the test images.
>
> Not all, fail only in envs/configs where libfdt devel doesn't exist. But I'm 
> not
> sure about this patch (*).
>
>> Patchew manually checks out the dtc
>> submodule in the main git checkout, but this is a bad idea. The
>> docker tests should never mess around with the developer's main
>> GIT checkout.
>
> Or in general, scripts should not mess around with developer's GIT checkouts,
> which is the reason ./configure doesn't do it?
>
> How about we clone/checkout dtc into a temporary dir from ./configure
> automatically instead?

I like this! Submodules cause lots of issues for us. Other users
building QEMU don't expect to have to clone submodules and we get
complaints back to the QEMU. Especially DTC which is always required.

Thanks,
Alistair