Re: [Qemu-devel] [PULL 0/3] QAPI patches for 2017-10-02

[Eric Blake]

On 10/02/2017 06:42 AM, address@hidden wrote:
> Hi,
> 
> This series seems to have some coding style problems. See output below for
> more information:
> 

> Checking PATCH 2/3: watchdog.h: Drop local redefinition of actions enum...
> ERROR: braces {} are necessary for all arms of this statement
> #57: FILE: hw/watchdog/watchdog.c:86:
> +    if (action < 0)
> [...]

Pre-existing problem, but would indeed be easy to fix up as part of this
series.  I don't know if that means Markus should respin the pull request?

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature