[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 0/3] QAPI patches for 2017-10-02
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PULL 0/3] QAPI patches for 2017-10-02 |
|
Date: |
Mon, 02 Oct 2017 19:17:05 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 10/02/2017 06:42 AM, address@hidden wrote:
>> Hi,
>>
>> This series seems to have some coding style problems. See output below for
>> more information:
>>
>
>> Checking PATCH 2/3: watchdog.h: Drop local redefinition of actions enum...
>> ERROR: braces {} are necessary for all arms of this statement
>> #57: FILE: hw/watchdog/watchdog.c:86:
>> + if (action < 0)
>> [...]
>
> Pre-existing problem, but would indeed be easy to fix up as part of this
> series. I don't know if that means Markus should respin the pull request?
I would've touched it up in my tree had I seen it in time, but I doubt
it's worth the bother now.
- [Qemu-devel] [PULL 0/3] QAPI patches for 2017-10-02, Markus Armbruster, 2017/10/02
- [Qemu-devel] [PULL 3/3] watchdog: Allow setting action on the fly, Markus Armbruster, 2017/10/02
- [Qemu-devel] [PULL 2/3] watchdog.h: Drop local redefinition of actions enum, Markus Armbruster, 2017/10/02
- [Qemu-devel] [PULL 1/3] qapi: Rename WatchdogExpirationAction enum, Markus Armbruster, 2017/10/02
- Re: [Qemu-devel] [PULL 0/3] QAPI patches for 2017-10-02, no-reply, 2017/10/02
- Re: [Qemu-devel] [PULL 0/3] QAPI patches for 2017-10-02, Peter Maydell, 2017/10/03