[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] tcg/mips: make some functions inline.
From: |
jiang.biao2 |
Subject: |
Re: [Qemu-devel] [PATCH] tcg/mips: make some functions inline. |
Date: |
Fri, 3 Nov 2017 08:37:14 +0800 (CST) |
> On 11/02/2017 12:23 PM, address@hidden wrote:
> > No, :) Just found some of these functions are inline and others are not
> > when reading
> > the code, the style looks inconsistent.
> >
> My preference would be to remove them all.
Should I commit another patch to do that? :)
> > Besides, The compiler may make default inline choices for some functions,
> > but may
> > not for some cases(some longer ones). Adding inline manually can guarantee
> > and
> > not hurt. :)
> The longer ones in particular should *not* be inline, so that we don't expand
> the size of the code unnecessarily. Which *can* hurt.
Got that, thanks for the reply.
Regards,