[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 6/6] hw/i386: deprecate the "isapc" machine
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [RFC PATCH 6/6] hw/i386: deprecate the "isapc" machine |
Date: |
Wed, 8 Nov 2017 00:29:47 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 11/07/2017 11:28 PM, Philippe Mathieu-Daudé wrote:
> Deprecated since 2.9.0, guests should be able to use "pc" instead.
I forgot to add Paolo's comment:
"but firmware code paths would be different, do we care?"
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/i386/pc_piix.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
> index c462b702ff..df4669c6d3 100644
> --- a/hw/i386/pc_piix.c
> +++ b/hw/i386/pc_piix.c
> @@ -1114,6 +1114,7 @@ static void isapc_machine_options(MachineClass *m)
> pcmc->smbios_legacy_mode = true;
> pcmc->has_reserved_memory = false;
> m->default_cpu_type = X86_CPU_TYPE_NAME("486");
> + m->deprecated_reason = "Use the \"pc\" machine instead";
> }
>
> DEFINE_PC_MACHINE(isapc, "isapc", pc_init_isa,
>
[Qemu-devel] [RFC PATCH 6/6] hw/i386: deprecate the "isapc" machine, Philippe Mathieu-Daudé, 2017/11/07
Re: [Qemu-devel] [RFC PATCH 0/6] generic way to deprecate machines, Daniel P. Berrange, 2017/11/08