Re: [Qemu-devel] Yet another git submodule rant

[Alexey Kardashevskiy]

On 10/11/17 21:41, Daniel P. Berrange wrote:
> On Fri, Nov 10, 2017 at 09:35:54PM +1100, Alexey Kardashevskiy wrote:
>> On 09/11/17 00:01, Daniel P. Berrange wrote:
>>> On Wed, Nov 08, 2017 at 09:26:01AM -0300, Philippe Mathieu-Daudé wrote:
>>>> On 11/08/2017 06:57 AM, Thomas Huth wrote:
>>>>>
>>>>> That automatic git submodule stuff now broke my workflow again. I
>>>>> usually keep the git repository on my laptop and then simply rsync the
>>>>> sources (without .git directories) to my target machine to compile it
>>>>> there. Used to work great for years. Now it's broken, the build process
>>>>> complains:
>>>>>
>>>>> GIT submodule checkout is out of date. Please run
>>>>>   scripts/git-submodule.sh update
>>>>> from the source directory checkout /home/thuth/devel/qemu
>>>>>
>>>>> Running "scripts/git-submodule.sh update" did not fix the issue at all -
>>>>> I first had to tinker with it for a while to find out that I simply have
>>>>> to delete ".git-submodule-status" in my git tree to fix the issue.
>>>>>
>>>>> I've got the feeling that all this submodule crap is constantly causing
>>>>> pain ... do we really need this? Can't we find another solution instead?
>>>>> Or at least stop modifying files automatically in the $SRC_PATH ?
>>>>
>>>> Also yesterday on IRC:
>>>>
>>>> <RaV3N> [...] I downloaded the qemu source from git and tried to compile
>>>> it. I am getting this:
>>>>
>>>> ./configure --static && make && sudo make install
>>>>  CC      ui/input-keymap.o
>>>> ui/input-keymap.c:8:10: fatal error: ui/input-keymap-linux-to-qcode.c:
>>>> No such file or directory
>>>
>>> I had a pull request merged yesterday later afternoon which possibly
>>> would address that problem, though hard hard to say for certain.
>>
>> wow, already? :(
>>
>> I still wonder why do not we checkout submodules into the build directory
>> and why .git-submodule-status is not there too...
> 
> That simply isn't the way submodules work, they are inherently part of
> the source tree, and the status file reflects that too.

Sorry, I am missing the point here. What precisely does prevent us from
checking out the required modules to the build directory and build them
there? git provides a submodule repository url and sha1 for the current
qemu branch.

Yes, the submodule tree inside the qemu tree might be different from the
one in the build directory but the purpose of all of this is to always
build the correct code - so this requirement is met. And it will still be
better than changing the $SRC_PATH when a user specifically asked not to do
that by calling "./configure --source-path='.



-- 
Alexey