[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] build: disarm the TCG unit test trap
From: |
Kashyap Chamarthy |
Subject: |
Re: [Qemu-devel] [PATCH v2] build: disarm the TCG unit test trap |
Date: |
Tue, 21 Nov 2017 16:00:00 +0100 |
User-agent: |
Mutt/1.6.0.1 (2016-04-01) |
On Tue, Nov 21, 2017 at 02:25:38PM +0000, Daniel P. Berrange wrote:
> Developers sometimes mistakenly run 'make test' instead of 'make check'.
> 'make test' triggers the ancient, unmaintained tcg unit tests in
> tests/tcg/Makefile which have long since ceased compiling.
>
> Even if someone fixes the TCG tests, it makes little sense to put
> them in a 'make test' target, rather they should be 'make check-tcg',
> possibly wired up as a dependency of 'make check'.
>
> In the meantime, this patch disarms the 'make test' trap by simply
> deleting it so users get an immediate error. This should be enough
> for them to remember to type 'make check' instead (or 'make help'
> to learn). It also deletes 'make speed' which is another route
> into the tcg tests.
Thanks; I mistakenly fell for this trap.
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
>
> Changed in v2:
>
> - Remove 'test' & 'speed' targets, instead of making 'test'
> a synonym for 'check'
>
> Makefile | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
Reviewed-by: Kashyap Chamarthy <address@hidden>
[...]
--
/kashyap