[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 02/20] include/fpu/softfloat: remove USE_SOFT
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v2 02/20] include/fpu/softfloat: remove USE_SOFTFLOAT_STRUCT_TYPES |
Date: |
Tue, 9 Jan 2018 14:43:37 +0000 |
On 9 January 2018 at 14:20, Laurent Vivier <address@hidden> wrote:
> Le 09/01/2018 à 15:14, Peter Maydell a écrit :
>> Is gcc's codegen still bad enough that we have to default to not
>> using the type-checking versions? If so, maybe we could at least
>> enable the type-checking on an --enable-debug build, so it doesn't
>> bitrot all the time.
>
> What means "bad enough"? for some targets it works fine.
I mean whatever the problem was that made us write the comment
A sufficiently clever compiler and
sane ABI should be able to see though these structs. However
x86/gcc 3.x seems to struggle a bit, so leave them disabled by default.
In theory the code generated should be no worse than without structs...
> The problem with that is if it is not enabled all the time it becomes
> broken really quick...
Yes, that's why I'd like it at least default-enabled for --enable-debug,
if we can't enable it always.
thanks
-- PMM
[Qemu-devel] [PATCH v2 05/20] include/fpu/softfloat: implement float16_set_sign helper, Alex Bennée, 2018/01/09
[Qemu-devel] [PATCH v2 03/20] include/fpu/softfloat: implement float16_abs helper, Alex Bennée, 2018/01/09
[Qemu-devel] [PATCH v2 06/20] include/fpu/softfloat: add some float16 constants, Alex Bennée, 2018/01/09