Re: [Qemu-devel] [PATCH v3 07/13] qapi: ensure stable sort ordering when checking QAPI entities

[Philippe Mathieu-Daudé]

On 01/15/2018 07:26 AM, Daniel P. Berrange wrote:
> Some early python 3.x versions will have different default
> ordering when calling the 'values()' method on a dict, compared
> to python 2.x and later 3.x versions. Explicitly sort the items
> to get a stable ordering.
> 
> Signed-off-by: Daniel P. Berrange <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

> ---
>  scripts/qapi.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/qapi.py b/scripts/qapi.py
> index b6a7b5139f..6266447eb0 100644
> --- a/scripts/qapi.py
> +++ b/scripts/qapi.py
> @@ -1678,7 +1678,7 @@ class QAPISchema(object):
>                  assert False
>  
>      def check(self):
> -        for ent in self._entity_dict.values():
> +        for (name, ent) in sorted(self._entity_dict.items()):
>              ent.check(self)
>  
>      def visit(self, visitor):
>