[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC 09/21] qapi: Don't absolutize include file n
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH RFC 09/21] qapi: Don't absolutize include file name in error messages |
Date: |
Tue, 06 Feb 2018 08:49:59 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 02/03/2018 03:08 AM, Markus Armbruster wrote:
>> Eric Blake <address@hidden> writes:
>>
>>> On 02/02/2018 07:03 AM, Markus Armbruster wrote:
>>>> Error messages print absolute filenames of included files even gave a
>>>
>>> s/even gave/even when given/
>>
>> I meant to write "even if the user gave". Is that okay?
>
> Yes, that works too.
>
>>
>>>> relative one on the command line:
>>>>
>>>> PYTHONPATH=scripts python -B tests/qapi-schema/test-qapi.py
>>>> tests/qapi-schema/include-cycle.json
>>>> In file included from tests/qapi-schema/include-cycle.json:1:
>>>> In file included from
>>>> /work/armbru/qemu/tests/qapi-schema/include-cycle-b.json:1:
>>>> /work/armbru/qemu/tests/qapi-schema/include-cycle-c.json:1: Inclusion
>>>> loop for include-cycle.json
>>>>
>>>> Improve this to
>>>>
>>>> In file included from tests/qapi-schema/include-cycle.json:1:
>>>> In file included from tests/qapi-schema/include-cycle-b.json:1:
>>>> tests/qapi-schema/include-cycle-c.json:1: Inclusion loop for
>>>> include-cycle.json
>>>
>>> Nice, and makes developing new qapi tests a little less painful since
>>> it's less modification to qapi-schema/*.err additions.
>>
>> Probably not, as our make rule strips off $(SRC_PATH):
>>
>> @perl -p -e 's|\Q$(SRC_PATH)\E/||g' $*.test.err | diff -q
>> $(SRC_PATH)/$*.err -
>>
>> I've kept that, because it might also occur in stack backtraces. I
>> think.
>
> I still recall having to hand-edit .err files when doing a naive "run
> the test to get the failure, then 'mv' the bad files into the expected
> filenames, then rerun the tests";
Whenever the Perl script does something, you can't simply move the
.test.err to .err. Annoying.
A make target check-accept could automate the work.
However, with this patch, the Perl script should do something less
often. I guess that's your point.
Sorry for being slow on the update :)
> so I'm not sure if our make rule was
> properly munging absolute names out of the file in the first place. I'm
> not too fussed about it, though, as adding new tests is less frequent
> and it's still fairly easy to learn if you did it right or not by
> whether 'make check' succeeds.
>
>>>> Signed-off-by: Markus Armbruster <address@hidden>
>>>> ---
>>>> scripts/qapi/common.py | 12 ++++++------
>>>> tests/qapi-schema/include-no-file.err | 2 +-
>>>> 2 files changed, 7 insertions(+), 7 deletions(-)
>>>>
>>>
>>> Reviewed-by: Eric Blake <address@hidden>
>>
>> Thanks!
>>
- Re: [Qemu-devel] [PATCH RFC 03/21] qapi: New classes QAPIGenC, QAPIGenH, QAPIGenDoc, (continued)
- Re: [Qemu-devel] [PATCH RFC 03/21] qapi: New classes QAPIGenC, QAPIGenH, QAPIGenDoc, Eric Blake, 2018/02/02
- Re: [Qemu-devel] [PATCH RFC 03/21] qapi: New classes QAPIGenC, QAPIGenH, QAPIGenDoc, Markus Armbruster, 2018/02/03
- Re: [Qemu-devel] [PATCH RFC 03/21] qapi: New classes QAPIGenC, QAPIGenH, QAPIGenDoc, Eric Blake, 2018/02/05
- Re: [Qemu-devel] [PATCH RFC 03/21] qapi: New classes QAPIGenC, QAPIGenH, QAPIGenDoc, Markus Armbruster, 2018/02/06
Re: [Qemu-devel] [PATCH RFC 03/21] qapi: New classes QAPIGenC, QAPIGenH, QAPIGenDoc, Marc-Andre Lureau, 2018/02/05
[Qemu-devel] [PATCH RFC 09/21] qapi: Don't absolutize include file name in error messages, Markus Armbruster, 2018/02/02
Re: [Qemu-devel] [PATCH RFC 09/21] qapi: Don't absolutize include file name in error messages, Marc-Andre Lureau, 2018/02/05
[Qemu-devel] [PATCH RFC 15/21] qapi: Record 'include' directives in intermediate representation, Markus Armbruster, 2018/02/02
[Qemu-devel] [PATCH RFC 13/21] qapi: Record 'include' directives in parse tree, Markus Armbruster, 2018/02/02
[Qemu-devel] [PATCH RFC 02/21] qapi: Generate up-to-date copyright notice, Markus Armbruster, 2018/02/02