[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RFC 09/21] qapi: Don't absolutize include file n

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH RFC 09/21] qapi: Don't absolutize include file name in error messages
Date: Tue, 6 Feb 2018 09:06:03 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2

On 02/06/2018 01:49 AM, Markus Armbruster wrote:

Probably not, as our make rule strips off $(SRC_PATH):

        @perl -p -e 's|\Q$(SRC_PATH)\E/||g' $*.test.err | diff -q 
$(SRC_PATH)/$*.err -

I've kept that, because it might also occur in stack backtraces.  I

Ideally, we don't have any stack backtraces ;) But we have indeed historically checked in .err files with a backtrace that a later patch in the series cleans up, so that part of the munging does indeed play a role in a clean 'make check' for documenting an expected weakness in the generator.

I still recall having to hand-edit .err files when doing a naive "run
the test to get the failure, then 'mv' the bad files into the expected
filenames, then rerun the tests";

Whenever the Perl script does something, you can't simply move the
.test.err to .err.  Annoying.

We could also munge the original output prior to creating .test.err; but that also has drawbacks if it eats something that would have been useful for debugging the test.

A make target check-accept could automate the work.

Yeah, but I'm not sure how often we'd need to invoke it, or even remember that it exists. But it would at least avoid the issue of having to debug a munged .test.err.

However, with this patch, the Perl script should do something less
often.  I guess that's your point.

Sorry for being slow on the update :)

No problem; I figure you've got a lot on your mind as you are trying to tie down loose ends before some much deserved time off.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]