[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 32/34] loader: allow arbitrary basename for
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [RFC PATCH 32/34] loader: allow arbitrary basename for fw_cfg file roms |
Date: |
Wed, 7 Feb 2018 12:22:58 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 06/02/2018 21:30, Roman Kagan wrote:
> + basename = strrchr(fw_path, '/');
> + if (basename && basename[1] == '\0') {
> + /* given path terminates with '/', append basename(file) */
> + basename = strrchr(file, '/');
> + if (basename) {
> + basename++;
> + } else {
> + basename = file;
> + }
> +
> + rom->fw_file = g_strdup_printf("%s%s", fw_path, basename);
> } else {
> - basename = rom->fw_file;
> + rom->fw_file = g_strdup(fw_path);
> }
Reusing basename is a bit unclear. Maybe:
assert(*fw_path);
if (fw_path[strlen(fw_path) - 1] == '/') {
/* given path terminates with '/', append basename(file) */
const char *basename = strrchr(file, '/');
if (basename) {
basename++;
} else {
basename = file;
}
rom->fw_file = g_strdup_printf("%s%s", fw_path, basename);
} else {
rom->fw_file = g_strdup(fw_path);
}
Thanks,
Paolo
- Re: [Qemu-devel] [RFC PATCH 25/34] scsi: add Hyper-V/VMBus SCSI controller, (continued)
- [Qemu-devel] [RFC PATCH 27/34] tests: hv-scsi: add start-stop test, Roman Kagan, 2018/02/06
- [Qemu-devel] [RFC PATCH 28/34] net: add RNDIS definitions, Roman Kagan, 2018/02/06
- [Qemu-devel] [RFC PATCH 31/34] hv-net: add .bootindex support, Roman Kagan, 2018/02/06
- [Qemu-devel] [RFC PATCH 29/34] net: add Hyper-V/VMBus network protocol definitions, Roman Kagan, 2018/02/06
- [Qemu-devel] [RFC PATCH 32/34] loader: allow arbitrary basename for fw_cfg file roms, Roman Kagan, 2018/02/06
- Re: [Qemu-devel] [RFC PATCH 32/34] loader: allow arbitrary basename for fw_cfg file roms,
Paolo Bonzini <=
- [Qemu-devel] [RFC PATCH 30/34] net: add Hyper-V/VMBus net adapter, Roman Kagan, 2018/02/06
- [Qemu-devel] [RFC PATCH 33/34] vmbus: add support for rom files, Roman Kagan, 2018/02/06
- [Qemu-devel] [RFC PATCH 34/34] hv-net: define default rom file name, Roman Kagan, 2018/02/06
- Re: [Qemu-devel] [RFC PATCH 00/34] Hyper-V / VMBus, no-reply, 2018/02/06
- Re: [Qemu-devel] [RFC PATCH 00/34] Hyper-V / VMBus, no-reply, 2018/02/06
- Re: [Qemu-devel] [RFC PATCH 00/34] Hyper-V / VMBus, no-reply, 2018/02/06
- Re: [Qemu-devel] [RFC PATCH 00/34] Hyper-V / VMBus, no-reply, 2018/02/06
- Re: [Qemu-devel] [RFC PATCH 00/34] Hyper-V / VMBus, no-reply, 2018/02/06