[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 3/5] cpu: add CPU_RESOLVING_TYPE macro

From: Eduardo Habkost
Subject: Re: [Qemu-devel] [PATCH v4 3/5] cpu: add CPU_RESOLVING_TYPE macro
Date: Wed, 7 Feb 2018 10:57:10 -0200
User-agent: Mutt/1.9.1 (2017-09-22)

On Wed, Feb 07, 2018 at 11:40:25AM +0100, Igor Mammedov wrote:
> it will be used for providing to cpu name resolving class for
> parsing cpu model for system and user emulation code.
> Along with change add target to null-machine tests, so
> that when switch to CPU_RESOLVING_TYPE happens,
> it would ensure that null-machine usecase still works.
> Signed-off-by: Igor Mammedov <address@hidden>
> Reviewed-by: Laurent Vivier <address@hidden> (m68k)
> Acked-by: David Gibson <address@hidden> (ppc)
> Acked-by: Bastian Koppelmann <address@hidden> (tricore)
> ---
> v2:
>   - use cortex-a57 for aarch64 test (Andrew Jones <address@hidden>)
>   - fix conflict due to cortex-a57 change in aarch64 entry
>     in previous patch
> v4:
>   - drop removal of default cpu_model in linux-user/main.c the was left
>     there after dropping *-user parts from v3 (Eduardo Habkost 
> <address@hidden>)

So, this macro is only used to find the providers of
CPUClass::class_by_name.  All the classes that set class_by_name
(except TYPE_CPU) are present in the patch.

Reviewed-by: Eduardo Habkost <address@hidden>

About TYPE_CPU: shouldn't we get rid of cpu_common_class_by_name
and just add assert(cc->parse_features) to parse_cpu_model()?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]