[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] cpu: drop unnecessary NULL check and cpu_common

From: Eduardo Habkost
Subject: Re: [Qemu-devel] [PATCH] cpu: drop unnecessary NULL check and cpu_common_class_by_name()
Date: Wed, 7 Feb 2018 13:25:52 -0200
User-agent: Mutt/1.9.1 (2017-09-22)

On Wed, Feb 07, 2018 at 03:30:57PM +0100, Igor Mammedov wrote:
> both do nothing as for the first all callers
>    parse_cpu_model() and qmp_query_cpu_model_()
> should provide non NULL value, so just abort if it's not so.
> While at it drop cpu_common_class_by_name() which is not need
> any more as every target has CPUClass::class_by_name callback
> by now, though abort in case a new arch will forget to define one.
> Signed-off-by: Igor Mammedov <address@hidden>

Reviewed-by: Eduardo Habkost <address@hidden>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]