[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] cpu: drop unnecessary NULL check and cpu_common
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [Qemu-devel] [PATCH] cpu: drop unnecessary NULL check and cpu_common_class_by_name() |
|
Date: |
Wed, 7 Feb 2018 13:25:52 -0200 |
|
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Wed, Feb 07, 2018 at 03:30:57PM +0100, Igor Mammedov wrote:
> both do nothing as for the first all callers
> parse_cpu_model() and qmp_query_cpu_model_()
> should provide non NULL value, so just abort if it's not so.
>
> While at it drop cpu_common_class_by_name() which is not need
> any more as every target has CPUClass::class_by_name callback
> by now, though abort in case a new arch will forget to define one.
>
> Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
--
Eduardo
- [Qemu-devel] [PATCH v4 0/5] generalize parsing of cpu_model (part 4), Igor Mammedov, 2018/02/07
- [Qemu-devel] [PATCH v4 2/5] tests: add machine 'none' with -cpu test, Igor Mammedov, 2018/02/07
- [Qemu-devel] [PATCH v4 4/5] Use cpu_create(type) instead of cpu_init(cpu_model), Igor Mammedov, 2018/02/07
- [Qemu-devel] [PATCH v4 5/5] cpu: get rid of unused cpu_init() defines, Igor Mammedov, 2018/02/07
- [Qemu-devel] [PATCH v4 1/5] nios2: 10m50_devboard: replace cpu_model with cpu_type, Igor Mammedov, 2018/02/07
- [Qemu-devel] [PATCH v4 3/5] cpu: add CPU_RESOLVING_TYPE macro, Igor Mammedov, 2018/02/07
- Re: [Qemu-devel] [PATCH v4 0/5] generalize parsing of cpu_model (part 4), Eduardo Habkost, 2018/02/07