[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 04/26] monitor/i386: use debug APIs when acce
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v7 04/26] monitor/i386: use debug APIs when accessing guest memory |
Date: |
Wed, 7 Feb 2018 17:53:36 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 07/02/2018 17:06, Brijesh Singh wrote:
>
> sum = 0;
> for(addr = start; addr < (start + size); addr++) {
> - uint8_t val = address_space_ldub(&address_space_memory, addr,
> - MEMTXATTRS_UNSPECIFIED, NULL);
> + uint8_t buf[0];
> + uint8_t val;
> + cpu_physical_memory_read_debug(addr, buf, 1);
> + val = ldub_p(buf);
This is a buffer overflow on "buf". All you need is
cpu_physical_memory_read_debug(addr, &val, 1);
Thanks,
Paolo
> /* BSD sum algorithm ('sum' Unix command) */
> sum = (sum >> 1) | (sum << 15);
- [Qemu-devel] [PATCH v7 01/26] memattrs: add debug attribute, Brijesh Singh, 2018/02/07
- [Qemu-devel] [PATCH v7 03/26] exec: add debug version of physical memory read and write API, Brijesh Singh, 2018/02/07
- [Qemu-devel] [PATCH v7 05/26] target/i386: add memory encryption feature cpuid support, Brijesh Singh, 2018/02/07
- [Qemu-devel] [PATCH v7 04/26] monitor/i386: use debug APIs when accessing guest memory, Brijesh Singh, 2018/02/07
- Re: [Qemu-devel] [PATCH v7 04/26] monitor/i386: use debug APIs when accessing guest memory,
Paolo Bonzini <=
- [Qemu-devel] [PATCH v7 06/26] machine: add -memory-encryption property, Brijesh Singh, 2018/02/07
- [Qemu-devel] [PATCH v7 07/26] kvm: update kvm.h to include memory encryption ioctls, Brijesh Singh, 2018/02/07
- [Qemu-devel] [PATCH v7 08/26] docs: add AMD Secure Encrypted Virtualization (SEV), Brijesh Singh, 2018/02/07
- [Qemu-devel] [PATCH v7 11/26] sev: register the guest memory range which may contain encrypted data, Brijesh Singh, 2018/02/07
- [Qemu-devel] [PATCH v7 09/26] accel: add Secure Encrypted Virtulization (SEV) object, Brijesh Singh, 2018/02/07
- [Qemu-devel] [PATCH v7 10/26] sev: add command to initialize the memory encryption context, Brijesh Singh, 2018/02/07
- [Qemu-devel] [PATCH v7 13/26] qmp: add query-sev command, Brijesh Singh, 2018/02/07
- [Qemu-devel] [PATCH v7 14/26] hmp: add 'info sev' command, Brijesh Singh, 2018/02/07