[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v6] s390x/cpu: expose the guest crash informatio

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v6] s390x/cpu: expose the guest crash information
Date: Wed, 7 Feb 2018 11:56:04 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2

On 02/07/2018 10:58 AM, Cornelia Huck wrote:
On Wed,  7 Feb 2018 12:38:33 +0000
Christian Borntraeger <address@hidden> wrote:

This patch is the s390 implementation of guest crash information,
similar to commit d187e08dc4 ("i386/cpu: add crash-information QOM
property") and the related commits. We will detect several crash
reasons, with the "disabled wait" being the most important one, since
this is used by all s390 guests as a "panic like" notification.

     "timestamp": {
         "seconds": 1518004739,
         "microseconds": 552563
     "event": "GUEST_PANICKED",
     "data": {
         "action": "pause",
         "info": {
             "core": 0,
             "psw-addr": 1102832,
             "reason": "disabledwait",
             "psw-mask": 562956395872256,
             "type": "s390"

Looks like the QAPI part is reasonable.

+{ 'enum': 'S390CrashReason',
+  'data': [ 'unknown',
+            'disabledwait',
+            'extintloop',
+            'pgmintloop',
+            'opintloop' ] }

Would some hyphens or underscores make this a bit more readable? FWICS,
QAPI would create something like S390_CRASH_REASON_DISABLED_WAIT for
'disabled-wait', which looks reasonable to me.

Yes, some legibility via word separators would help.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]