[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/27] qcow2: Let qcow2_create() handle protocol
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH 03/27] qcow2: Let qcow2_create() handle protocol layer |
Date: |
Fri, 9 Feb 2018 14:57:41 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 2018-02-08 20:23, Kevin Wolf wrote:
> Currently, qcow2_create() only parses the QemuOpts and then calls
> qcow2_create2() for the actual image creation, which includes both the
> creation of the actual file on the file system and writing a valid empty
> qcow2 image into that file.
>
> The plan is that qcow2_create2() becomes the function that implements
> the functionality for a future 'blockdev-create' QMP command, which only
> creates the qcow2 layer on an already opened file node.
>
> This is a first step towards that goal: Let's move out anything that
> deals with the protocol layer from qcow2_create2() into qcow2_create().
> This means that qcow2_create2() doesn't need a file name any more.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
> block/qcow2.c | 64
> +++++++++++++++++++++++++++++++++++------------------------
> 1 file changed, 38 insertions(+), 26 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 00/27] x-blockdev-create for protocols and qcow2, Kevin Wolf, 2018/02/08
- [Qemu-devel] [PATCH 02/27] block/qapi: Add qcow2 create options to schema, Kevin Wolf, 2018/02/08
- [Qemu-devel] [PATCH 04/27] qcow2: Pass BlockdevCreateOptions to qcow2_create2(), Kevin Wolf, 2018/02/08
- [Qemu-devel] [PATCH 03/27] qcow2: Let qcow2_create() handle protocol layer, Kevin Wolf, 2018/02/08
- Re: [Qemu-devel] [PATCH 03/27] qcow2: Let qcow2_create() handle protocol layer,
Max Reitz <=
- [Qemu-devel] [PATCH 01/27] block/qapi: Introduce BlockdevCreateOptions, Kevin Wolf, 2018/02/08
- [Qemu-devel] [PATCH 05/27] qcow2: Use BlockdevRef in qcow2_create2(), Kevin Wolf, 2018/02/08
- [Qemu-devel] [PATCH 06/27] qcow2: Use QCryptoBlockCreateOptions in qcow2_create2(), Kevin Wolf, 2018/02/08
- [Qemu-devel] [PATCH 07/27] qcow2: Handle full/falloc preallocation in qcow2_create2(), Kevin Wolf, 2018/02/08