qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 19/29] qapi: Make code-generating visitors us


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v2 19/29] qapi: Make code-generating visitors use QAPIGen more
Date: Mon, 12 Feb 2018 15:06:24 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

On 02/11/2018 03:35 AM, Markus Armbruster wrote:
The use of QAPIGen is rather shallow so far: most of the output
accumulation is not converted.  Take the next step: convert output
accumulation in the code-generating visitor classes.  Helper functions
outside these classes are not converted.

Signed-off-by: Markus Armbruster <address@hidden>
---
  scripts/qapi/commands.py   | 71 ++++++++++++++++------------------------
  scripts/qapi/common.py     | 13 ++++++++
  scripts/qapi/doc.py        | 74 ++++++++++++++++++++----------------------
  scripts/qapi/events.py     | 55 ++++++++++++-------------------
  scripts/qapi/introspect.py | 56 +++++++++++++-------------------
  scripts/qapi/types.py      | 81 +++++++++++++++++++---------------------------
  scripts/qapi/visit.py      | 80 +++++++++++++++++++--------------------------
  7 files changed, 188 insertions(+), 242 deletions(-)


Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



reply via email to

[Prev in Thread] Current Thread [Next in Thread]